]> git.neil.brown.name Git - wiggle.git/commitdiff
merge: fix a problem with unmatchable hunks.
authorNeilBrown <neil@brown.name>
Sat, 3 Oct 2020 09:30:34 +0000 (19:30 +1000)
committerNeilBrown <neil@brown.name>
Sat, 3 Oct 2020 09:30:34 +0000 (19:30 +1000)
If the patch contains hunks that cannot be matched, wiggle cannot to
anything really useful, but sometimes it does something bad and produces
a badly formatted result.

In these cases, the hunk must get placed somewhere, and it is possible
that two hunks could line up with different places in the same line of
the original.

As wiggle normally expands conflicts to cover whole lines, to display
this coherently, you would need something like

<<<
chosen line
||||
hunk1- before
hunk2- before
===
hunk1- after
hunk2- after
>>>

But wiggle assumes that a hunk header marks the end of a conflict, so
bad things happen here.
I don't want to display the hunk header, so I think the best option is

<<<
chosen line
|||
hunk1- before
===
hunk1- after
>>>
<<<
|||
hunk2- before
===
hunk2- after
>>>

To achieve this, we don't stop collecting a conflict when we hit a
hunk-header moving forward, but when we print the conflict out, we
detect those hunk headers, and do the above.
If the final hunk doesn't actually contain any differences, don't
bother printing it.

Signed-off-by: NeilBrown <neil@brown.name>
merge2.c
tests/linux/iomap/merge
tests/linux/raid1-A/merge
tests/lustre/pool/merge [new file with mode: 0644]
tests/lustre/pool/orig [new file with mode: 0644]
tests/lustre/pool/patch [new file with mode: 0644]

index 49f43f649119d9d27de053a0bdee46c0886811e1..435f859d905e4954ced680896ae68d44b585dee2 100644 (file)
--- a/merge2.c
+++ b/merge2.c
@@ -264,10 +264,6 @@ int isolate_conflicts(struct file af, struct file bf, struct file cf,
                        /* now the forward search */
                        newlines = 0;
                        for (j = i+1; m[j].type != End; j++) {
-                               if (m[j].type == Extraneous &&
-                                   bf.list[m[j].b].start[0] == '\0')
-                                       /* hunk header - not conflict any more */
-                                       break;
                                if (m[j].type == Extraneous) {
                                        for (k = 0; k < m[j].bl; k++)
                                                if (ends_line(bf.list[m[j].b+k]))
@@ -638,6 +634,9 @@ static int printrange(FILE *out, struct file *f, int start, int len,
        return lines;
 }
 
+static const char *conflict_types[] = {
+       "", " border"," conflict"," wiggle" };
+
 int print_merge(FILE *out, struct file *a, struct file *b, struct file *c,
                int words, struct merge *merger,
                struct merge *mpos, int streampos, int offsetpos)
@@ -646,6 +645,7 @@ int print_merge(FILE *out, struct file *a, struct file *b, struct file *c,
        int lineno = 1;
        int rv = 0;
        int offset = INT_MAX;
+       int first_matched;
 
        for (m = merger; m->type != End ; m++) {
                struct merge *cm;
@@ -660,7 +660,7 @@ int print_merge(FILE *out, struct file *a, struct file *b, struct file *c,
                               m->a, m->a+m->al-1,
                               m->b, m->b+m->bl-1,
                               m->c, m->c+m->cl-1,
-                              m->in_conflict ? " in_conflict" : "",
+                              conflict_types[m->in_conflict],
                               m->lo, m->hi);
 
                while (m->in_conflict) {
@@ -682,7 +682,7 @@ int print_merge(FILE *out, struct file *a, struct file *b, struct file *c,
                                rv = lineno;
                        if (do_trace)
                                for (cm = m; cm->in_conflict; cm++) {
-                                       printf("{%s: %d-%d,%d-%d,%d-%d%s(%d,%d)}\n",
+                                       printf("{%s: %d-%d,%d-%d,%d-%d%s(%d,%d)}%s\n",
                                               cm->type==Unmatched?"Unmatched":
                                               cm->type==Unchanged?"Unchanged":
                                               cm->type==Extraneous?"Extraneous":
@@ -692,8 +692,12 @@ int print_merge(FILE *out, struct file *a, struct file *b, struct file *c,
                                               cm->a, cm->a+cm->al-1,
                                               cm->b, cm->b+cm->bl-1,
                                               cm->c, cm->c+cm->cl-1,
-                                              cm->in_conflict ? " in_conflict" : "",
-                                              cm->lo, cm->hi);
+                                              conflict_types[m->in_conflict],
+                                              cm->lo, cm->hi,
+                                              (cm->type == Extraneous &&
+                                               b->list[cm->b].start[0] == '\0') ?
+                                              b->list[cm->b].start+1: ""
+                                       );
                                        if (cm->in_conflict == 1 && cm != m)
                                                break;
                                }
@@ -724,11 +728,24 @@ int print_merge(FILE *out, struct file *a, struct file *b, struct file *c,
                        }
                        if (cm == mpos && streampos == 0)
                                rv = lineno;
+               restart:
                        fputs(words ? "|||" : "||||||| expected\n", out);
                        if (!words)
                                lineno++;
                        st1 = st;
+                       first_matched = 1;
                        for (cm = m; cm->in_conflict; cm++) {
+                               if (cm->type == Extraneous &&
+                                   b->list[cm->b].start[0] == '\0') {
+                                       /* This is a hunk header, skip it and possibly
+                                        * abort this section
+                                        */
+                                       if (first_matched)
+                                               continue;
+                                       break;
+                               }
+                               if (cm->type != Unchanged && cm->type != Unmatched)
+                                       first_matched = 0;
                                if (cm == mpos && streampos == 1)
                                        offset = offsetpos;
                                if (cm->in_conflict == 1 && cm != m) {
@@ -746,7 +763,43 @@ int print_merge(FILE *out, struct file *a, struct file *b, struct file *c,
                        if (!words)
                                lineno++;
                        st1 = st;
+                       first_matched = 1;
                        for (cm = m; cm->in_conflict; cm++) {
+                               if (cm->type == Extraneous &&
+                                   b->list[cm->b].start[0] == '\0') {
+                                       /* This is a hunk header, skip it and possibly
+                                        * abort this section and restart.
+                                        */
+                                       if (first_matched)
+                                               continue;
+                                       m = cm;
+                                       /* If remaining merges are all
+                                        * Extraneous, Unchanged, or Unmatched,
+                                        * we don't need them.
+                                        */
+                                       while (cm->in_conflict > 1 &&
+                                              (cm->type == Extraneous ||
+                                               cm->type == Unmatched ||
+                                               cm->type == Unchanged))
+                                               cm ++;
+                                       if (!cm->in_conflict)
+                                               /* Nothing more to report */
+                                               break;
+                                       if (cm->in_conflict == 1 &&
+                                              (cm->type == Extraneous ||
+                                               cm->type == Unmatched ||
+                                               cm->type == Unchanged))
+                                               /* border between conflicts, but
+                                                * still nothing to report.
+                                                */
+                                               break;
+                                       fputs(words ? ">>>" : ">>>>>>> replacement\n", out);
+                                       fputs(words ? "<<<" : "<<<<<<< found\n", out);
+                                       st = 0;
+                                       goto restart;
+                               }
+                               if (cm->type != Unchanged && cm->type != Unmatched)
+                                       first_matched = 0;
                                if (cm == mpos && streampos == 2)
                                        offset = offsetpos;
                                if (cm->in_conflict == 1 && cm != m) {
@@ -833,7 +886,7 @@ int print_merge(FILE *out, struct file *a, struct file *b, struct file *c,
                               m->a, m->a+m->al-1,
                               m->b, m->b+m->bl-1,
                               m->c, m->c+m->cl-1,
-                              m->in_conflict ? " in_conflict" : "",
+                              conflict_types[m->in_conflict],
                               m->lo, m->hi);
                }
                if (m == mpos)
index df2ab5705ee49fe32463d64d91df26482a6b2db0..203a57649591c07618d635a641fe445a72d866a7 100644 (file)
@@ -266,7 +266,8 @@ EXPORT_SYMBOL(ioport_unmap);
 #ifdef CONFIG_PCI
 /* Hide the details if this is a MMIO or PIO address space and just do what
 <<<<<<< found
- * you expect in the correct way. */||||||| expected
+ * you expect in the correct way. */
+||||||| expected
  * you expect from them in the correct way.
  *
  * @maxlen specifies the maximum length to map. If you want to get access to
@@ -325,7 +326,6 @@ void __iomem *pci_iomap_range(struct pci_dev *dev, int bar,
                return ioremap_nocache(start, len);
        }
 >>>>>>> replacement
-
 /**
  * pci_iomap - create a virtual mapping cookie for a PCI BAR
  * @dev: PCI device that owns the BAR
index 96d17304c5fdaf667e05b7571464137617ba41e5..e25500edc06f040ad8410c5a278fd64b3bec91d7 100644 (file)
@@ -918,6 +918,7 @@ static int make_request(mddev_t *mddev, struct bio * bio)
 <<<<<<< found
                }
 
+               atomic_inc(&r1_bio->remaining);
 ||||||| expected
                bio_list_add(&bl, mbio);
        }
@@ -930,7 +931,6 @@ static int make_request(mddev_t *mddev, struct bio * bio)
        kfree(behind_pages); /* the behind pages are attached to the bios now */
 
 >>>>>>> replacement
-               atomic_inc(&r1_bio->remaining);
 <<<<<<< found
                spin_lock_irqsave(&conf->device_lock, flags);
                bio_list_add(&conf->pending_bio_list, mbio);
diff --git a/tests/lustre/pool/merge b/tests/lustre/pool/merge
new file mode 100644 (file)
index 0000000..6af428f
--- /dev/null
@@ -0,0 +1,1183 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * GPL HEADER START
+ *
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 only,
+ * as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but
+ * WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * General Public License version 2 for more details (a copy is included
+ * in the LICENSE file that accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License
+ * version 2 along with this program; If not, see
+ * http://www.gnu.org/licenses/gpl-2.0.html
+ *
+ * GPL HEADER END
+ */
+/*
+ * Copyright (c) 2007, 2010, Oracle and/or its affiliates. All rights reserved.
+ * Use is subject to license terms.
+ *
+ * Copyright (c) 2010, 2017, Intel Corporation.
+ */
+/*
+ * This file is part of Lustre, http://www.lustre.org/
+ * Lustre is a trademark of Sun Microsystems, Inc.
+ *
+ * lustre/ldlm/ldlm_pool.c
+ *
+ * Author: Yury Umanets <umka@clusterfs.com>
+ */
+
+/*
+ * Idea of this code is rather simple. Each second, for each server namespace
+ * we have SLV - server lock volume which is calculated on current number of
+ * granted locks, grant speed for past period, etc - that is, locking load.
+ * This SLV number may be thought as a flow definition for simplicity. It is
+ * sent to clients with each occasion to let them know what is current load
+ * situation on the server. By default, at the beginning, SLV on server is
+ * set max value which is calculated as the following: allow to one client
+ * have all locks of limit ->pl_limit for 10h.
+ *
+ * Next, on clients, number of cached locks is not limited artificially in any
+ * way as it was before. Instead, client calculates CLV, that is, client lock
+ * volume for each lock and compares it with last SLV from the server. CLV is
+ * calculated as the number of locks in LRU * lock live time in seconds. If
+ * CLV > SLV - lock is canceled.
+ *
+ * Client has LVF, that is, lock volume factor which regulates how much
+ * sensitive client should be about last SLV from server. The higher LVF is the
+ * more locks will be canceled on client. Default value for it is 1. Setting LVF
+ * to 2 means that client will cancel locks 2 times faster.
+ *
+ * Locks on a client will be canceled more intensively in these cases:
+ * (1) if SLV is smaller, that is, load is higher on the server;
+ * (2) client has a lot of locks (the more locks are held by client, the bigger
+ *     chances that some of them should be canceled);
+ * (3) client has old locks (taken some time ago);
+ *
+ * Thus, according to flow paradigm that we use for better understanding SLV,
+ * CLV is the volume of particle in flow described by SLV. According to this,
+ * if flow is getting thinner, more and more particles become outside of it and
+ * as particles are locks, they should be canceled.
+ *
+ * General idea of this belongs to Vitaly Fertman (vitaly@clusterfs.com).
+ * Andreas Dilger (adilger@clusterfs.com) proposed few nice ideas like using
+ * LVF and many cleanups. Flow definition to allow more easy understanding of
+ * the logic belongs to Nikita Danilov (nikita@clusterfs.com) as well as many
+ * cleanups and fixes. And design and implementation are done by Yury Umanets
+ * (umka@clusterfs.com).
+ *
+ * Glossary for terms used:
+ *
+ * pl_limit - Number of allowed locks in pool. Applies to server and client
+ * side (tunable);
+ *
+ * pl_granted - Number of granted locks (calculated);
+ * pl_grant_rate - Number of granted locks for last T (calculated);
+ * pl_cancel_rate - Number of canceled locks for last T (calculated);
+ * pl_grant_speed - Grant speed (GR - CR) for last T (calculated);
+ * pl_grant_plan - Planned number of granted locks for next T (calculated);
+ * pl_server_lock_volume - Current server lock volume (calculated);
+ *
+ * As it may be seen from list above, we have few possible tunables which may
+ * affect behavior much. They all may be modified via sysfs. However, they also
+ * give a possibility for constructing few pre-defined behavior policies. If
+ * none of predefines is suitable for a working pattern being used, new one may
+ * be "constructed" via sysfs tunables.
+ */
+
+#define DEBUG_SUBSYSTEM S_LDLM
+
+#include <lustre_dlm.h>
+#include <cl_object.h>
+#include <obd_class.h>
+#include <obd_support.h>
+#include "ldlm_internal.h"
+
+/*
+ * 50 ldlm locks for 1MB of RAM.
+ */
+#define LDLM_POOL_HOST_L ((NUM_CACHEPAGES >> (20 - PAGE_SHIFT)) * 50)
+
+/*
+ * Maximal possible grant step plan in %.
+ */
+#define LDLM_POOL_MAX_GSP (30)
+
+/*
+ * Minimal possible grant step plan in %.
+ */
+#define LDLM_POOL_MIN_GSP (1)
+
+/*
+ * This controls the speed of reaching LDLM_POOL_MAX_GSP
+ * with increasing thread period.
+ */
+#define LDLM_POOL_GSP_STEP_SHIFT (2)
+
+/*
+ * LDLM_POOL_GSP% of all locks is default GP.
+ */
+#define LDLM_POOL_GP(L)   (((L) * LDLM_POOL_MAX_GSP) / 100)
+
+/*
+ * Max age for locks on clients.
+ */
+#define LDLM_POOL_MAX_AGE (36000)
+
+/*
+ * The granularity of SLV calculation.
+ */
+#define LDLM_POOL_SLV_SHIFT (10)
+
+static inline u64 dru(u64 val, u32 shift, int round_up)
+{
+       return (val + (round_up ? (1 << shift) - 1 : 0)) >> shift;
+}
+
+static inline u64 ldlm_pool_slv_max(u32 L)
+{
+       /*
+        * Allow to have all locks for 1 client for 10 hrs.
+        * Formula is the following: limit * 10h / 1 client.
+        */
+       u64 lim = (u64)L *  LDLM_POOL_MAX_AGE / 1;
+       return lim;
+}
+
+static inline u64 ldlm_pool_slv_min(u32 L)
+{
+       return 1;
+}
+
+enum {
+       LDLM_POOL_FIRST_STAT = 0,
+       LDLM_POOL_GRANTED_STAT = LDLM_POOL_FIRST_STAT,
+       LDLM_POOL_GRANT_STAT,
+       LDLM_POOL_CANCEL_STAT,
+       LDLM_POOL_GRANT_RATE_STAT,
+       LDLM_POOL_CANCEL_RATE_STAT,
+       LDLM_POOL_GRANT_PLAN_STAT,
+       LDLM_POOL_SLV_STAT,
+       LDLM_POOL_SHRINK_REQTD_STAT,
+       LDLM_POOL_SHRINK_FREED_STAT,
+       LDLM_POOL_RECALC_STAT,
+       LDLM_POOL_TIMING_STAT,
+       LDLM_POOL_LAST_STAT
+};
+
+/**
+ * Calculates suggested grant_step in % of available locks for passed
+ * @period. This is later used in grant_plan calculations.
+ */
+static inline int ldlm_pool_t2gsp(unsigned int t)
+{
+       /*
+        * This yields 1% grant step for anything below LDLM_POOL_GSP_STEP
+        * and up to 30% for anything higher than LDLM_POOL_GSP_STEP.
+        *
+        * How this will affect execution is the following:
+        *
+        * - for thread period 1s we will have grant_step 1% which good from
+        * pov of taking some load off from server and push it out to clients.
+        * This is like that because 1% for grant_step means that server will
+        * not allow clients to get lots of locks in short period of time and
+        * keep all old locks in their caches. Clients will always have to
+        * get some locks back if they want to take some new;
+        *
+        * - for thread period 10s (which is default) we will have 23% which
+        * means that clients will have enough of room to take some new locks
+        * without getting some back. All locks from this 23% which were not
+        * taken by clients in current period will contribute in SLV growing.
+        * SLV growing means more locks cached on clients until limit or grant
+        * plan is reached.
+        */
+       return LDLM_POOL_MAX_GSP -
+               ((LDLM_POOL_MAX_GSP - LDLM_POOL_MIN_GSP) >>
+                (t >> LDLM_POOL_GSP_STEP_SHIFT));
+}
+
+/**
+ * Recalculates next stats on passed @pl.
+ *
+ * \pre ->pl_lock is locked.
+ */
+static void ldlm_pool_recalc_stats(struct ldlm_pool *pl, timeout_t period)
+{
+       int grant_plan = pl->pl_grant_plan;
+       u64 slv = pl->pl_server_lock_volume;
+       int granted = atomic_read(&pl->pl_granted);
+       int grant_rate = atomic_read(&pl->pl_grant_rate) / period;
+       int cancel_rate = atomic_read(&pl->pl_cancel_rate) / period;
+
+       lprocfs_counter_add(pl->pl_stats, LDLM_POOL_SLV_STAT,
+                           slv);
+       lprocfs_counter_add(pl->pl_stats, LDLM_POOL_GRANTED_STAT,
+                           granted);
+       lprocfs_counter_add(pl->pl_stats, LDLM_POOL_GRANT_RATE_STAT,
+                           grant_rate);
+       lprocfs_counter_add(pl->pl_stats, LDLM_POOL_GRANT_PLAN_STAT,
+                           grant_plan);
+       lprocfs_counter_add(pl->pl_stats, LDLM_POOL_CANCEL_RATE_STAT,
+                           cancel_rate);
+}
+
+/**
+ * Sets SLV and Limit from container_of(pl, struct ldlm_namespace,
+ * ns_pool)->ns_obd tp passed @pl.
+ */
+static void ldlm_cli_pool_pop_slv(struct ldlm_pool *pl)
+{
+       struct obd_device *obd;
+
+       /*
+        * Get new SLV and Limit from obd which is updated with coming
+        * RPCs.
+        */
+       obd = container_of(pl, struct ldlm_namespace,
+                          ns_pool)->ns_obd;
+       read_lock(&obd->obd_pool_lock);
+       pl->pl_server_lock_volume = obd->obd_pool_slv;
+       atomic_set(&pl->pl_limit, obd->obd_pool_limit);
+       read_unlock(&obd->obd_pool_lock);
+}
+
+/**
+ * Recalculates client size pool @pl according to current SLV and Limit.
+ */
+static int ldlm_cli_pool_recalc(struct ldlm_pool *pl)
+{
+       timeout_t recalc_interval_sec;
+       int ret;
+
+       recalc_interval_sec = ktime_get_seconds() - pl->pl_recalc_time;
+       if (recalc_interval_sec < pl->pl_recalc_period)
+               return 0;
+
+       spin_lock(&pl->pl_lock);
+       /*
+        * Check if we need to recalc lists now.
+        */
+       recalc_interval_sec = ktime_get_seconds() - pl->pl_recalc_time;
+       if (recalc_interval_sec < pl->pl_recalc_period) {
+               spin_unlock(&pl->pl_lock);
+               return 0;
+<<<<<<< found
+       }
+||||||| expected
+        */
+       ldlm_pool_recalc_grant_plan(pl);
+
+       pl->pl_recalc_time = ktime_get_real_seconds();
+       lprocfs_counter_add(pl->pl_stats, LDLM_POOL_TIMING_STAT,
+                           recalc_interval_sec);
+       spin_unlock(&pl->pl_lock);
+=======
+        */
+       ldlm_pool_recalc_grant_plan(pl);
+
+       pl->pl_recalc_time = ktime_get_seconds();
+       lprocfs_counter_add(pl->pl_stats, LDLM_POOL_TIMING_STAT,
+                           recalc_interval_sec);
+       spin_unlock(&pl->pl_lock);
+>>>>>>> replacement
+<<<<<<< found
+||||||| expected
+ */
+static int ldlm_cli_pool_recalc(struct ldlm_pool *pl)
+{
+       time64_t recalc_interval_sec;
+       int ret;
+=======
+ */
+static int ldlm_cli_pool_recalc(struct ldlm_pool *pl)
+{
+       timeout_t recalc_interval_sec;
+       int ret;
+>>>>>>> replacement
+
+<<<<<<< found
+       /*
+        * Make sure that pool knows last SLV and Limit from obd.
+        */
+       ldlm_cli_pool_pop_slv(pl);
+
+       spin_unlock(&pl->pl_lock);
+||||||| expected
+       ENTRY;
+
+       recalc_interval_sec = ktime_get_real_seconds() - pl->pl_recalc_time;
+       if (recalc_interval_sec < pl->pl_recalc_period)
+               return 0;
+
+=======
+       ENTRY;
+
+       recalc_interval_sec = ktime_get_seconds() - pl->pl_recalc_time;
+       if (recalc_interval_sec < pl->pl_recalc_period)
+               return 0;
+
+>>>>>>> replacement
+<<<<<<< found
+||||||| expected
+       /*
+        * Check if we need to recalc lists now.
+        */
+       recalc_interval_sec = ktime_get_real_seconds() - pl->pl_recalc_time;
+       if (recalc_interval_sec < pl->pl_recalc_period) {
+               spin_unlock(&pl->pl_lock);
+=======
+       /*
+        * Check if we need to recalc lists now.
+        */
+       recalc_interval_sec = ktime_get_seconds() - pl->pl_recalc_time;
+       if (recalc_interval_sec < pl->pl_recalc_period) {
+               spin_unlock(&pl->pl_lock);
+>>>>>>> replacement
+
+       /*
+        * In the time of canceling locks on client we do not need to maintain
+        * sharp timing, we only want to cancel locks asap according to new SLV.
+        * It may be called when SLV has changed much, this is why we do not
+        * take into account pl->pl_recalc_time here.
+        */
+       ret = ldlm_cancel_lru(container_of(pl, struct ldlm_namespace, ns_pool),
+                             0, LCF_ASYNC, 0);
+
+       spin_lock(&pl->pl_lock);
+       /*
+        * Time of LRU resizing might be longer than period,
+        * so update after LRU resizing rather than before it.
+        */
+       pl->pl_recalc_time = ktime_get_seconds();
+       lprocfs_counter_add(pl->pl_stats, LDLM_POOL_TIMING_STAT,
+                           recalc_interval_sec);
+       spin_unlock(&pl->pl_lock);
+       return ret;
+}
+
+/**
+ * This function is main entry point for memory pressure handling on client
+ * side.  Main goal of this function is to cancel some number of locks on
+ * passed @pl according to @nr and @gfp_mask.
+ */
+static int ldlm_cli_pool_shrink(struct ldlm_pool *pl,
+                               int nr, gfp_t gfp_mask)
+{
+       struct ldlm_namespace *ns;
+       int unused;
+
+       ns = container_of(pl, struct ldlm_namespace, ns_pool);
+
+       /*
+        * Do not cancel locks in case lru resize is disabled for this ns.
+        */
+       if (!ns_connect_lru_resize(ns))
+               return 0;
+
+       /*
+        * Make sure that pool knows last SLV and Limit from obd.
+        */
+       spin_lock(&pl->pl_lock);
+       ldlm_cli_pool_pop_slv(pl);
+       spin_unlock(&pl->pl_lock);
+
+       spin_lock(&ns->ns_lock);
+       unused = ns->ns_nr_unused;
+       spin_unlock(&ns->ns_lock);
+
+       if (nr == 0)
+               return (unused / 100) * sysctl_vfs_cache_pressure;
+       else
+               return ldlm_cancel_lru(ns, nr, LCF_ASYNC, 0);
+}
+
+static const struct ldlm_pool_ops ldlm_cli_pool_ops = {
+       .po_recalc = ldlm_cli_pool_recalc,
+       .po_shrink = ldlm_cli_pool_shrink
+};
+
+/**
+ * Pool recalc wrapper. Will call either client or server pool recalc callback
+ * depending what pool @pl is used.
+ *
+ * \retval             time in seconds for the next recalc of this pool
+ */
+<<<<<<< found
+static int ldlm_pool_recalc(struct ldlm_pool *pl)
+{
+       u32 recalc_interval_sec;
+||||||| expected
+time64_t ldlm_pool_recalc(struct ldlm_pool *pl)
+{
+       time64_t recalc_interval_sec;
+=======
+time64_t ldlm_pool_recalc(struct ldlm_pool *pl)
+{
+       timeout_t recalc_interval_sec;
+>>>>>>> replacement
+       int count;
+
+       recalc_interval_sec = ktime_get_seconds() - pl->pl_recalc_time;
+       if (recalc_interval_sec > 0) {
+               spin_lock(&pl->pl_lock);
+<<<<<<< found
+               recalc_interval_sec = ktime_get_real_seconds() -
+                                     pl->pl_recalc_time;
+||||||| expected
+               recalc_interval_sec = ktime_get_real_seconds() -
+                       pl->pl_recalc_time;
+=======
+               recalc_interval_sec = ktime_get_seconds() - pl->pl_recalc_time;
+>>>>>>> replacement
+
+               if (recalc_interval_sec > 0) {
+                       /*
+                        * Update pool statistics every recalc interval.
+                        */
+                       ldlm_pool_recalc_stats(pl, recalc_interval_sec);
+
+                       /*
+                        * Zero out all rates and speed for the last period.
+                        */
+                       atomic_set(&pl->pl_grant_rate, 0);
+                       atomic_set(&pl->pl_cancel_rate, 0);
+               }
+               spin_unlock(&pl->pl_lock);
+       }
+
+       if (pl->pl_ops->po_recalc) {
+               count = pl->pl_ops->po_recalc(pl);
+               lprocfs_counter_add(pl->pl_stats, LDLM_POOL_RECALC_STAT,
+                                   count);
+       }
+
+<<<<<<< found
+       recalc_interval_sec = pl->pl_recalc_time - ktime_get_real_seconds() +
+                             pl->pl_recalc_period;
+       if (recalc_interval_sec <= 0) {
+               /* DEBUG: should be re-removed after LU-4536 is fixed */
+               CDEBUG(D_DLMTRACE,
+                      "%s: Negative interval(%ld), too short period(%ld)\n",
+                      pl->pl_name, (long)recalc_interval_sec,
+                      (long)pl->pl_recalc_period);
+
+               /* Prevent too frequent recalculation. */
+               recalc_interval_sec = 1;
+       }
+
+       return recalc_interval_sec;
+||||||| expected
+       recalc_interval_sec = pl->pl_recalc_time - ktime_get_real_seconds() +
+                             pl->pl_recalc_period;
+       if (recalc_interval_sec <= 0) {
+               /* DEBUG: should be re-removed after LU-4536 is fixed */
+               CDEBUG(D_DLMTRACE, "%s: Negative interval(%lld), too short period(%lld)\n",
+                      pl->pl_name, recalc_interval_sec,
+                      (s64)pl->pl_recalc_period);
+
+               /* Prevent too frequent recalculation. */
+               recalc_interval_sec = 1;
+       }
+
+       return recalc_interval_sec;
+=======
+       return pl->pl_recalc_time + pl->pl_recalc_period;
+>>>>>>> replacement
+}
+
+/*
+ * Pool shrink wrapper. Will call either client or server pool recalc callback
+ * depending what pool pl is used. When nr == 0, just return the number of
+ * freeable locks. Otherwise, return the number of canceled locks.
+ */
+static int ldlm_pool_shrink(struct ldlm_pool *pl, int nr, gfp_t gfp_mask)
+{
+       int cancel = 0;
+
+       if (pl->pl_ops->po_shrink) {
+               cancel = pl->pl_ops->po_shrink(pl, nr, gfp_mask);
+               if (nr > 0) {
+                       lprocfs_counter_add(pl->pl_stats,
+                                           LDLM_POOL_SHRINK_REQTD_STAT,
+                                           nr);
+                       lprocfs_counter_add(pl->pl_stats,
+                                           LDLM_POOL_SHRINK_FREED_STAT,
+                                           cancel);
+                       CDEBUG(D_DLMTRACE,
+                              "%s: request to shrink %d locks, shrunk %d\n",
+                              pl->pl_name, nr, cancel);
+               }
+       }
+       return cancel;
+}
+
+static int lprocfs_pool_state_seq_show(struct seq_file *m, void *unused)
+{
+       int granted, grant_rate, cancel_rate;
+       int grant_speed, lvf;
+       struct ldlm_pool *pl = m->private;
+       timeout_t period;
+       u64 slv, clv;
+       u32 limit;
+
+       spin_lock(&pl->pl_lock);
+       slv = pl->pl_server_lock_volume;
+       clv = pl->pl_client_lock_volume;
+       limit = atomic_read(&pl->pl_limit);
+       granted = atomic_read(&pl->pl_granted);
+       period = ktime_get_seconds() - pl->pl_recalc_time;
+       if (period <= 0)
+               period = 1;
+       grant_rate = atomic_read(&pl->pl_grant_rate) / period;
+       cancel_rate = atomic_read(&pl->pl_cancel_rate) / period;
+       grant_speed = grant_rate - cancel_rate;
+       lvf = atomic_read(&pl->pl_lock_volume_factor);
+       spin_unlock(&pl->pl_lock);
+
+       seq_printf(m, "LDLM pool state (%s):\n"
+                     "  SLV: %llu\n"
+                     "  CLV: %llu\n"
+                     "  LVF: %d\n",
+                     pl->pl_name, slv, clv, (lvf * 100) >> 8);
+
+       seq_printf(m, "  GR:  %d\n  CR:  %d\n  GS:  %d\n"
+                     "  G:   %d\n  L:   %d\n",
+                     grant_rate, cancel_rate, grant_speed,
+                     granted, limit);
+
+       return 0;
+}
+
+LDEBUGFS_SEQ_FOPS_RO(lprocfs_pool_state);
+
+static ssize_t grant_speed_show(struct kobject *kobj, struct attribute *attr,
+                               char *buf)
+{
+       struct ldlm_pool *pl = container_of(kobj, struct ldlm_pool,
+                                           pl_kobj);
+       int grant_speed;
+       timeout_t period;
+
+       spin_lock(&pl->pl_lock);
+       /* serialize with ldlm_pool_recalc */
+       period = ktime_get_seconds() - pl->pl_recalc_time;
+       if (period <= 0)
+               period = 1;
+       grant_speed = (atomic_read(&pl->pl_grant_rate) -
+                      atomic_read(&pl->pl_cancel_rate)) / period;
+       spin_unlock(&pl->pl_lock);
+       return sprintf(buf, "%d\n", grant_speed);
+}
+LUSTRE_RO_ATTR(grant_speed);
+
+LDLM_POOL_SYSFS_READER_SHOW(grant_plan, int);
+LUSTRE_RO_ATTR(grant_plan);
+
+LDLM_POOL_SYSFS_READER_SHOW(recalc_period, int);
+LDLM_POOL_SYSFS_WRITER_STORE(recalc_period, int);
+LUSTRE_RW_ATTR(recalc_period);
+
+LDLM_POOL_SYSFS_READER_NOLOCK_SHOW(server_lock_volume, u64);
+LUSTRE_RO_ATTR(server_lock_volume);
+
+LDLM_POOL_SYSFS_READER_NOLOCK_SHOW(client_lock_volume, u64);
+LUSTRE_RO_ATTR(client_lock_volume);
+
+LDLM_POOL_SYSFS_READER_NOLOCK_SHOW(limit, atomic);
+LDLM_POOL_SYSFS_WRITER_NOLOCK_STORE(limit, atomic);
+LUSTRE_RW_ATTR(limit);
+
+LDLM_POOL_SYSFS_READER_NOLOCK_SHOW(granted, atomic);
+LUSTRE_RO_ATTR(granted);
+
+LDLM_POOL_SYSFS_READER_NOLOCK_SHOW(cancel_rate, atomic);
+LUSTRE_RO_ATTR(cancel_rate);
+
+LDLM_POOL_SYSFS_READER_NOLOCK_SHOW(grant_rate, atomic);
+LUSTRE_RO_ATTR(grant_rate);
+
+static ssize_t lock_volume_factor_show(struct kobject *kobj,
+                                      struct attribute *attr,
+                                      char *buf)
+{
+       struct ldlm_pool *pl = container_of(kobj, struct ldlm_pool, pl_kobj);
+       unsigned long tmp;
+
+       tmp = (atomic_read(&pl->pl_lock_volume_factor) * 100) >> 8;
+       return sprintf(buf, "%lu\n", tmp);
+}
+
+static ssize_t lock_volume_factor_store(struct kobject *kobj,
+                                       struct attribute *attr,
+                                       const char *buffer,
+                                       size_t count)
+{
+       struct ldlm_pool *pl = container_of(kobj, struct ldlm_pool, pl_kobj);
+       unsigned long tmp;
+       int rc;
+
+       rc = kstrtoul(buffer, 10, &tmp);
+       if (rc < 0) {
+               return rc;
+       }
+
+       tmp = (tmp << 8) / 100;
+       atomic_set(&pl->pl_lock_volume_factor, tmp);
+
+       return count;
+
+}
+LUSTRE_RW_ATTR(lock_volume_factor);
+
+static ssize_t recalc_time_show(struct kobject *kobj,
+                               struct attribute *attr,
+                               char *buf)
+{
+       struct ldlm_pool *pl = container_of(kobj, struct ldlm_pool, pl_kobj);
+
+       return snprintf(buf, PAGE_SIZE, "%llu\n",
+                       ktime_get_seconds() - pl->pl_recalc_time);
+}
+LUSTRE_RO_ATTR(recalc_time);
+
+/* These are for pools in /sys/fs/lustre/ldlm/namespaces/.../pool */
+static struct attribute *ldlm_pl_attrs[] = {
+       &lustre_attr_grant_speed.attr,
+       &lustre_attr_grant_plan.attr,
+       &lustre_attr_recalc_period.attr,
+       &lustre_attr_server_lock_volume.attr,
+       &lustre_attr_client_lock_volume.attr,
+       &lustre_attr_recalc_time.attr,
+       &lustre_attr_limit.attr,
+       &lustre_attr_granted.attr,
+       &lustre_attr_cancel_rate.attr,
+       &lustre_attr_grant_rate.attr,
+       &lustre_attr_lock_volume_factor.attr,
+       NULL,
+};
+
+static void ldlm_pl_release(struct kobject *kobj)
+{
+       struct ldlm_pool *pl = container_of(kobj, struct ldlm_pool,
+                                           pl_kobj);
+       complete(&pl->pl_kobj_unregister);
+}
+
+static struct kobj_type ldlm_pl_ktype = {
+       .default_attrs  = ldlm_pl_attrs,
+       .sysfs_ops      = &lustre_sysfs_ops,
+       .release        = ldlm_pl_release,
+};
+
+static int ldlm_pool_sysfs_init(struct ldlm_pool *pl)
+{
+       struct ldlm_namespace *ns = container_of(pl, struct ldlm_namespace,
+                                                ns_pool);
+       int err;
+
+       init_completion(&pl->pl_kobj_unregister);
+       err = kobject_init_and_add(&pl->pl_kobj, &ldlm_pl_ktype, &ns->ns_kobj,
+                                  "pool");
+
+       return err;
+}
+
+static int ldlm_pool_debugfs_init(struct ldlm_pool *pl)
+{
+       struct ldlm_namespace *ns = container_of(pl, struct ldlm_namespace,
+                                                ns_pool);
+       struct dentry *debugfs_ns_parent;
+       struct ldebugfs_vars pool_vars[2];
+       int rc = 0;
+
+       debugfs_ns_parent = ns->ns_debugfs_entry;
+       if (IS_ERR_OR_NULL(debugfs_ns_parent)) {
+               CERROR("%s: debugfs entry is not initialized\n",
+                      ldlm_ns_name(ns));
+               rc = -EINVAL;
+               goto out;
+       }
+       pl->pl_debugfs_entry = debugfs_create_dir("pool", debugfs_ns_parent);
+
+       memset(pool_vars, 0, sizeof(pool_vars));
+
+       ldlm_add_var(&pool_vars[0], pl->pl_debugfs_entry, "state", pl,
+                    &lprocfs_pool_state_fops);
+
+       pl->pl_stats = lprocfs_alloc_stats(LDLM_POOL_LAST_STAT -
+                                          LDLM_POOL_FIRST_STAT, 0);
+       if (!pl->pl_stats) {
+               rc = -ENOMEM;
+               goto out;
+       }
+
+       lprocfs_counter_init(pl->pl_stats, LDLM_POOL_GRANTED_STAT,
+                            LPROCFS_CNTR_AVGMINMAX | LPROCFS_CNTR_STDDEV,
+                            "granted", "locks");
+       lprocfs_counter_init(pl->pl_stats, LDLM_POOL_GRANT_STAT,
+                            LPROCFS_CNTR_AVGMINMAX | LPROCFS_CNTR_STDDEV,
+                            "grant", "locks");
+       lprocfs_counter_init(pl->pl_stats, LDLM_POOL_CANCEL_STAT,
+                            LPROCFS_CNTR_AVGMINMAX | LPROCFS_CNTR_STDDEV,
+                            "cancel", "locks");
+       lprocfs_counter_init(pl->pl_stats, LDLM_POOL_GRANT_RATE_STAT,
+                            LPROCFS_CNTR_AVGMINMAX | LPROCFS_CNTR_STDDEV,
+                            "grant_rate", "locks/s");
+       lprocfs_counter_init(pl->pl_stats, LDLM_POOL_CANCEL_RATE_STAT,
+                            LPROCFS_CNTR_AVGMINMAX | LPROCFS_CNTR_STDDEV,
+                            "cancel_rate", "locks/s");
+       lprocfs_counter_init(pl->pl_stats, LDLM_POOL_GRANT_PLAN_STAT,
+                            LPROCFS_CNTR_AVGMINMAX | LPROCFS_CNTR_STDDEV,
+                            "grant_plan", "locks/s");
+       lprocfs_counter_init(pl->pl_stats, LDLM_POOL_SLV_STAT,
+                            LPROCFS_CNTR_AVGMINMAX | LPROCFS_CNTR_STDDEV,
+                            "slv", "slv");
+       lprocfs_counter_init(pl->pl_stats, LDLM_POOL_SHRINK_REQTD_STAT,
+                            LPROCFS_CNTR_AVGMINMAX | LPROCFS_CNTR_STDDEV,
+                            "shrink_request", "locks");
+       lprocfs_counter_init(pl->pl_stats, LDLM_POOL_SHRINK_FREED_STAT,
+                            LPROCFS_CNTR_AVGMINMAX | LPROCFS_CNTR_STDDEV,
+                            "shrink_freed", "locks");
+       lprocfs_counter_init(pl->pl_stats, LDLM_POOL_RECALC_STAT,
+                            LPROCFS_CNTR_AVGMINMAX | LPROCFS_CNTR_STDDEV,
+                            "recalc_freed", "locks");
+       lprocfs_counter_init(pl->pl_stats, LDLM_POOL_TIMING_STAT,
+                            LPROCFS_CNTR_AVGMINMAX | LPROCFS_CNTR_STDDEV,
+                            "recalc_timing", "sec");
+       debugfs_create_file("stats", 0644, pl->pl_debugfs_entry, pl->pl_stats,
+                           &ldebugfs_stats_seq_fops);
+
+out:
+       return rc;
+}
+
+static void ldlm_pool_sysfs_fini(struct ldlm_pool *pl)
+{
+       kobject_put(&pl->pl_kobj);
+       wait_for_completion(&pl->pl_kobj_unregister);
+}
+
+static void ldlm_pool_debugfs_fini(struct ldlm_pool *pl)
+{
+       if (pl->pl_stats) {
+               lprocfs_free_stats(&pl->pl_stats);
+               pl->pl_stats = NULL;
+       }
+       debugfs_remove_recursive(pl->pl_debugfs_entry);
+}
+
+int ldlm_pool_init(struct ldlm_pool *pl, struct ldlm_namespace *ns,
+                  int idx, enum ldlm_side client)
+{
+       int rc;
+
+       spin_lock_init(&pl->pl_lock);
+       atomic_set(&pl->pl_granted, 0);
+       pl->pl_recalc_time = ktime_get_seconds();
+       atomic_set(&pl->pl_lock_volume_factor, 1 << 8);
+
+       atomic_set(&pl->pl_grant_rate, 0);
+       atomic_set(&pl->pl_cancel_rate, 0);
+       pl->pl_grant_plan = LDLM_POOL_GP(LDLM_POOL_HOST_L);
+
+       snprintf(pl->pl_name, sizeof(pl->pl_name), "ldlm-pool-%s-%d",
+                ldlm_ns_name(ns), idx);
+
+       atomic_set(&pl->pl_limit, 1);
+       pl->pl_server_lock_volume = 0;
+       pl->pl_ops = &ldlm_cli_pool_ops;
+       pl->pl_recalc_period = LDLM_POOL_CLI_DEF_RECALC_PERIOD;
+       pl->pl_client_lock_volume = 0;
+       rc = ldlm_pool_debugfs_init(pl);
+       if (rc)
+               return rc;
+
+       rc = ldlm_pool_sysfs_init(pl);
+       if (rc)
+               return rc;
+
+       CDEBUG(D_DLMTRACE, "Lock pool %s is initialized\n", pl->pl_name);
+
+       return rc;
+}
+
+void ldlm_pool_fini(struct ldlm_pool *pl)
+{
+       ldlm_pool_sysfs_fini(pl);
+       ldlm_pool_debugfs_fini(pl);
+
+       /*
+        * Pool should not be used after this point. We can't free it here as
+        * it lives in struct ldlm_namespace, but still interested in catching
+        * any abnormal using cases.
+        */
+       POISON(pl, 0x5a, sizeof(*pl));
+}
+
+/**
+ * Add new taken ldlm lock @lock into pool @pl accounting.
+ */
+void ldlm_pool_add(struct ldlm_pool *pl, struct ldlm_lock *lock)
+{
+       /*
+        * FLOCK locks are special in a sense that they are almost never
+        * cancelled, instead special kind of lock is used to drop them.
+        * also there is no LRU for flock locks, so no point in tracking
+        * them anyway.
+        */
+       if (lock->l_resource->lr_type == LDLM_FLOCK)
+               return;
+
+       atomic_inc(&pl->pl_granted);
+       atomic_inc(&pl->pl_grant_rate);
+       lprocfs_counter_incr(pl->pl_stats, LDLM_POOL_GRANT_STAT);
+       /*
+        * Do not do pool recalc for client side as all locks which
+        * potentially may be canceled has already been packed into
+        * enqueue/cancel rpc. Also we do not want to run out of stack
+        * with too long call paths.
+        */
+}
+
+/**
+ * Remove ldlm lock @lock from pool @pl accounting.
+ */
+void ldlm_pool_del(struct ldlm_pool *pl, struct ldlm_lock *lock)
+{
+       /*
+        * Filter out FLOCK locks. Read above comment in ldlm_pool_add().
+        */
+       if (lock->l_resource->lr_type == LDLM_FLOCK)
+               return;
+
+       LASSERT(atomic_read(&pl->pl_granted) > 0);
+       atomic_dec(&pl->pl_granted);
+       atomic_inc(&pl->pl_cancel_rate);
+
+       lprocfs_counter_incr(pl->pl_stats, LDLM_POOL_CANCEL_STAT);
+}
+
+/**
+ * Returns current @pl SLV.
+ *
+ * \pre ->pl_lock is not locked.
+ */
+u64 ldlm_pool_get_slv(struct ldlm_pool *pl)
+{
+       u64 slv;
+
+       spin_lock(&pl->pl_lock);
+       slv = pl->pl_server_lock_volume;
+       spin_unlock(&pl->pl_lock);
+       return slv;
+}
+
+/**
+ * Sets passed @clv to @pl.
+ *
+ * \pre ->pl_lock is not locked.
+ */
+void ldlm_pool_set_clv(struct ldlm_pool *pl, u64 clv)
+{
+       spin_lock(&pl->pl_lock);
+       pl->pl_client_lock_volume = clv;
+       spin_unlock(&pl->pl_lock);
+}
+
+/**
+ * Returns current LVF from @pl.
+ */
+u32 ldlm_pool_get_lvf(struct ldlm_pool *pl)
+{
+       return atomic_read(&pl->pl_lock_volume_factor);
+}
+
+static int ldlm_pool_granted(struct ldlm_pool *pl)
+{
+       return atomic_read(&pl->pl_granted);
+}
+
+/*
+ * count locks from all namespaces (if possible). Returns number of
+ * cached locks.
+ */
+static unsigned long ldlm_pools_count(enum ldlm_side client, gfp_t gfp_mask)
+{
+       unsigned long total = 0;
+       int nr_ns;
+       struct ldlm_namespace *ns;
+       struct ldlm_namespace *ns_old = NULL; /* loop detection */
+
+       if (client == LDLM_NAMESPACE_CLIENT && !(gfp_mask & __GFP_FS))
+               return 0;
+
+       /*
+        * Find out how many resources we may release.
+        */
+       for (nr_ns = ldlm_namespace_nr_read(client);
+            nr_ns > 0; nr_ns--) {
+               mutex_lock(ldlm_namespace_lock(client));
+               if (list_empty(ldlm_namespace_list(client))) {
+                       mutex_unlock(ldlm_namespace_lock(client));
+                       return 0;
+               }
+               ns = ldlm_namespace_first_locked(client);
+
+               if (ns == ns_old) {
+                       mutex_unlock(ldlm_namespace_lock(client));
+                       break;
+               }
+
+               if (ldlm_ns_empty(ns)) {
+                       ldlm_namespace_move_to_inactive_locked(ns, client);
+                       mutex_unlock(ldlm_namespace_lock(client));
+                       continue;
+               }
+
+               if (!ns_old)
+                       ns_old = ns;
+
+               ldlm_namespace_get(ns);
+               ldlm_namespace_move_to_active_locked(ns, client);
+               mutex_unlock(ldlm_namespace_lock(client));
+               total += ldlm_pool_shrink(&ns->ns_pool, 0, gfp_mask);
+               ldlm_namespace_put(ns);
+       }
+
+       return total;
+}
+
+static unsigned long ldlm_pools_scan(enum ldlm_side client, int nr,
+                                    gfp_t gfp_mask)
+{
+       unsigned long freed = 0;
+       int tmp, nr_ns;
+       struct ldlm_namespace *ns;
+
+       if (client == LDLM_NAMESPACE_CLIENT && !(gfp_mask & __GFP_FS))
+               return -1;
+
+       /*
+        * Shrink at least ldlm_namespace_nr_read(client) namespaces.
+        */
+       for (tmp = nr_ns = ldlm_namespace_nr_read(client);
+            tmp > 0; tmp--) {
+               int cancel, nr_locks;
+
+               /*
+                * Do not call shrink under ldlm_namespace_lock(client)
+                */
+               mutex_lock(ldlm_namespace_lock(client));
+               if (list_empty(ldlm_namespace_list(client))) {
+                       mutex_unlock(ldlm_namespace_lock(client));
+                       break;
+               }
+               ns = ldlm_namespace_first_locked(client);
+               ldlm_namespace_get(ns);
+               ldlm_namespace_move_to_active_locked(ns, client);
+               mutex_unlock(ldlm_namespace_lock(client));
+
+               nr_locks = ldlm_pool_granted(&ns->ns_pool);
+               /*
+                * We use to shrink propotionally but with new shrinker API,
+                * we lost the total number of freeable locks.
+                */
+               cancel = 1 + min_t(int, nr_locks, nr / nr_ns);
+               freed += ldlm_pool_shrink(&ns->ns_pool, cancel, gfp_mask);
+               ldlm_namespace_put(ns);
+       }
+       /*
+        * we only decrease the SLV in server pools shrinker, return
+        * SHRINK_STOP to kernel to avoid needless loop. LU-1128
+        */
+       return freed;
+}
+
+static unsigned long ldlm_pools_cli_count(struct shrinker *s,
+                                         struct shrink_control *sc)
+{
+       return ldlm_pools_count(LDLM_NAMESPACE_CLIENT, sc->gfp_mask);
+}
+
+static unsigned long ldlm_pools_cli_scan(struct shrinker *s,
+                                        struct shrink_control *sc)
+{
+       return ldlm_pools_scan(LDLM_NAMESPACE_CLIENT, sc->nr_to_scan,
+                              sc->gfp_mask);
+}
+
+static void ldlm_pools_recalc(struct work_struct *ws);
+static DECLARE_DELAYED_WORK(ldlm_recalc_pools, ldlm_pools_recalc);
+
+static void ldlm_pools_recalc(struct work_struct *ws)
+{
+       enum ldlm_side client = LDLM_NAMESPACE_CLIENT;
+       struct ldlm_namespace *ns;
+       struct ldlm_namespace *ns_old = NULL;
+       /* seconds of sleep if no active namespaces */
+<<<<<<< found
+       time64_t time = LDLM_POOL_CLI_DEF_RECALC_PERIOD;
+||||||| expected
+       time64_t delay = side == LDLM_NAMESPACE_SERVER ?
+                                LDLM_POOL_SRV_DEF_RECALC_PERIOD :
+                                LDLM_POOL_CLI_DEF_RECALC_PERIOD;
+=======
+       time64_t delay = ktime_get_seconds() +
+                        (side == LDLM_NAMESPACE_SERVER ?
+                         LDLM_POOL_SRV_DEF_RECALC_PERIOD :
+                         LDLM_POOL_CLI_DEF_RECALC_PERIOD);
+>>>>>>> replacement
+       int nr;
+
+       /*
+        * Recalc at least ldlm_namespace_nr_read(client) namespaces.
+        */
+       for (nr = ldlm_namespace_nr_read(client); nr > 0; nr--) {
+               int skip;
+               /*
+                * Lock the list, get first @ns in the list, getref, move it
+                * to the tail, unlock and call pool recalc. This way we avoid
+                * calling recalc under @ns lock what is really good as we get
+                * rid of potential deadlock on client nodes when canceling
+                * locks synchronously.
+                */
+               mutex_lock(ldlm_namespace_lock(client));
+               if (list_empty(ldlm_namespace_list(client))) {
+                       mutex_unlock(ldlm_namespace_lock(client));
+                       break;
+               }
+               ns = ldlm_namespace_first_locked(client);
+
+               if (ns_old == ns) { /* Full pass complete */
+                       mutex_unlock(ldlm_namespace_lock(client));
+                       break;
+               }
+
+               /* We got an empty namespace, need to move it back to inactive
+                * list.
+                * The race with parallel resource creation is fine:
+                * - If they do namespace_get before our check, we fail the
+                *   check and they move this item to the end of the list anyway
+                * - If we do the check and then they do namespace_get, then
+                *   we move the namespace to inactive and they will move
+                *   it back to active (synchronised by the lock, so no clash
+                *   there).
+                */
+               if (ldlm_ns_empty(ns)) {
+                       ldlm_namespace_move_to_inactive_locked(ns, client);
+                       mutex_unlock(ldlm_namespace_lock(client));
+                       continue;
+               }
+
+               if (!ns_old)
+                       ns_old = ns;
+
+               spin_lock(&ns->ns_lock);
+               /*
+                * skip ns which is being freed, and we don't want to increase
+                * its refcount again, not even temporarily. bz21519 & LU-499.
+                */
+               if (ns->ns_stopping) {
+                       skip = 1;
+               } else {
+                       skip = 0;
+                       ldlm_namespace_get(ns);
+               }
+               spin_unlock(&ns->ns_lock);
+
+               ldlm_namespace_move_to_active_locked(ns, client);
+               mutex_unlock(ldlm_namespace_lock(client));
+
+               /*
+                * After setup is done - recalc the pool.
+                */
+               if (!skip) {
+                       time64_t ttime = ldlm_pool_recalc(&ns->ns_pool);
+
+                       if (ttime < time)
+                               time = ttime;
+
+                       ldlm_namespace_put(ns);
+               }
+       }
+
+       /* Wake up the blocking threads from time to time. */
+       ldlm_bl_thread_wakeup();
+
+       delay -= ktime_get_seconds();
+       if (delay <= 0) {
+               /* Prevent too frequent recalculation. */
+               CDEBUG(D_DLMTRACE, "Negative interval(%lld)\n", delay);
+               delay = 1;
+       }
+
+       schedule_delayed_work(&ldlm_recalc_pools, time * HZ);
+}
+
+static int ldlm_pools_thread_start(void)
+{
+       time64_t delay;
+
+       schedule_delayed_work(&ldlm_recalc_pools, 0);
+
+<<<<<<< found
+       return 0;
+}
+
+static void ldlm_pools_thread_stop(void)
+{
+||||||| expected
+       DEF_SHRINKER_VAR(shcvar, ldlm_pools_cli_shrink,
+                        ldlm_pools_cli_count, ldlm_pools_cli_scan);
+
+       schedule_delayed_work(&ldlm_pools_recalc_work,
+                             LDLM_POOL_CLI_DEF_RECALC_PERIOD);
+       ldlm_pools_srv_shrinker = set_shrinker(DEFAULT_SEEKS, &shsvar);
+=======
+       DEF_SHRINKER_VAR(shcvar, ldlm_pools_cli_shrink,
+                        ldlm_pools_cli_count, ldlm_pools_cli_scan);
+
+#ifdef HAVE_SERVER_SUPPORT
+       delay = min(LDLM_POOL_SRV_DEF_RECALC_PERIOD,
+                   LDLM_POOL_CLI_DEF_RECALC_PERIOD);
+#else
+       delay = LDLM_POOL_CLI_DEF_RECALC_PERIOD;
+#endif
+
+       schedule_delayed_work(&ldlm_pools_recalc_work, delay);
+       ldlm_pools_srv_shrinker = set_shrinker(DEFAULT_SEEKS, &shsvar);
+>>>>>>> replacement
+       cancel_delayed_work_sync(&ldlm_recalc_pools);
+}
+
+static struct shrinker ldlm_pools_cli_shrinker = {
+       .count_objects  = ldlm_pools_cli_count,
+       .scan_objects   = ldlm_pools_cli_scan,
+       .seeks          = DEFAULT_SEEKS,
+};
+
+int ldlm_pools_init(void)
+{
+       int rc;
+
+       rc = ldlm_pools_thread_start();
+       if (!rc)
+               rc = register_shrinker(&ldlm_pools_cli_shrinker);
+
+       return rc;
+}
+
+void ldlm_pools_fini(void)
+{
+       unregister_shrinker(&ldlm_pools_cli_shrinker);
+
+       ldlm_pools_thread_stop();
+}
diff --git a/tests/lustre/pool/orig b/tests/lustre/pool/orig
new file mode 100644 (file)
index 0000000..c66436a
--- /dev/null
@@ -0,0 +1,985 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * GPL HEADER START
+ *
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 only,
+ * as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but
+ * WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * General Public License version 2 for more details (a copy is included
+ * in the LICENSE file that accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License
+ * version 2 along with this program; If not, see
+ * http://www.gnu.org/licenses/gpl-2.0.html
+ *
+ * GPL HEADER END
+ */
+/*
+ * Copyright (c) 2007, 2010, Oracle and/or its affiliates. All rights reserved.
+ * Use is subject to license terms.
+ *
+ * Copyright (c) 2010, 2017, Intel Corporation.
+ */
+/*
+ * This file is part of Lustre, http://www.lustre.org/
+ * Lustre is a trademark of Sun Microsystems, Inc.
+ *
+ * lustre/ldlm/ldlm_pool.c
+ *
+ * Author: Yury Umanets <umka@clusterfs.com>
+ */
+
+/*
+ * Idea of this code is rather simple. Each second, for each server namespace
+ * we have SLV - server lock volume which is calculated on current number of
+ * granted locks, grant speed for past period, etc - that is, locking load.
+ * This SLV number may be thought as a flow definition for simplicity. It is
+ * sent to clients with each occasion to let them know what is current load
+ * situation on the server. By default, at the beginning, SLV on server is
+ * set max value which is calculated as the following: allow to one client
+ * have all locks of limit ->pl_limit for 10h.
+ *
+ * Next, on clients, number of cached locks is not limited artificially in any
+ * way as it was before. Instead, client calculates CLV, that is, client lock
+ * volume for each lock and compares it with last SLV from the server. CLV is
+ * calculated as the number of locks in LRU * lock live time in seconds. If
+ * CLV > SLV - lock is canceled.
+ *
+ * Client has LVF, that is, lock volume factor which regulates how much
+ * sensitive client should be about last SLV from server. The higher LVF is the
+ * more locks will be canceled on client. Default value for it is 1. Setting LVF
+ * to 2 means that client will cancel locks 2 times faster.
+ *
+ * Locks on a client will be canceled more intensively in these cases:
+ * (1) if SLV is smaller, that is, load is higher on the server;
+ * (2) client has a lot of locks (the more locks are held by client, the bigger
+ *     chances that some of them should be canceled);
+ * (3) client has old locks (taken some time ago);
+ *
+ * Thus, according to flow paradigm that we use for better understanding SLV,
+ * CLV is the volume of particle in flow described by SLV. According to this,
+ * if flow is getting thinner, more and more particles become outside of it and
+ * as particles are locks, they should be canceled.
+ *
+ * General idea of this belongs to Vitaly Fertman (vitaly@clusterfs.com).
+ * Andreas Dilger (adilger@clusterfs.com) proposed few nice ideas like using
+ * LVF and many cleanups. Flow definition to allow more easy understanding of
+ * the logic belongs to Nikita Danilov (nikita@clusterfs.com) as well as many
+ * cleanups and fixes. And design and implementation are done by Yury Umanets
+ * (umka@clusterfs.com).
+ *
+ * Glossary for terms used:
+ *
+ * pl_limit - Number of allowed locks in pool. Applies to server and client
+ * side (tunable);
+ *
+ * pl_granted - Number of granted locks (calculated);
+ * pl_grant_rate - Number of granted locks for last T (calculated);
+ * pl_cancel_rate - Number of canceled locks for last T (calculated);
+ * pl_grant_speed - Grant speed (GR - CR) for last T (calculated);
+ * pl_grant_plan - Planned number of granted locks for next T (calculated);
+ * pl_server_lock_volume - Current server lock volume (calculated);
+ *
+ * As it may be seen from list above, we have few possible tunables which may
+ * affect behavior much. They all may be modified via sysfs. However, they also
+ * give a possibility for constructing few pre-defined behavior policies. If
+ * none of predefines is suitable for a working pattern being used, new one may
+ * be "constructed" via sysfs tunables.
+ */
+
+#define DEBUG_SUBSYSTEM S_LDLM
+
+#include <lustre_dlm.h>
+#include <cl_object.h>
+#include <obd_class.h>
+#include <obd_support.h>
+#include "ldlm_internal.h"
+
+/*
+ * 50 ldlm locks for 1MB of RAM.
+ */
+#define LDLM_POOL_HOST_L ((NUM_CACHEPAGES >> (20 - PAGE_SHIFT)) * 50)
+
+/*
+ * Maximal possible grant step plan in %.
+ */
+#define LDLM_POOL_MAX_GSP (30)
+
+/*
+ * Minimal possible grant step plan in %.
+ */
+#define LDLM_POOL_MIN_GSP (1)
+
+/*
+ * This controls the speed of reaching LDLM_POOL_MAX_GSP
+ * with increasing thread period.
+ */
+#define LDLM_POOL_GSP_STEP_SHIFT (2)
+
+/*
+ * LDLM_POOL_GSP% of all locks is default GP.
+ */
+#define LDLM_POOL_GP(L)   (((L) * LDLM_POOL_MAX_GSP) / 100)
+
+/*
+ * Max age for locks on clients.
+ */
+#define LDLM_POOL_MAX_AGE (36000)
+
+/*
+ * The granularity of SLV calculation.
+ */
+#define LDLM_POOL_SLV_SHIFT (10)
+
+static inline u64 dru(u64 val, u32 shift, int round_up)
+{
+       return (val + (round_up ? (1 << shift) - 1 : 0)) >> shift;
+}
+
+static inline u64 ldlm_pool_slv_max(u32 L)
+{
+       /*
+        * Allow to have all locks for 1 client for 10 hrs.
+        * Formula is the following: limit * 10h / 1 client.
+        */
+       u64 lim = (u64)L *  LDLM_POOL_MAX_AGE / 1;
+       return lim;
+}
+
+static inline u64 ldlm_pool_slv_min(u32 L)
+{
+       return 1;
+}
+
+enum {
+       LDLM_POOL_FIRST_STAT = 0,
+       LDLM_POOL_GRANTED_STAT = LDLM_POOL_FIRST_STAT,
+       LDLM_POOL_GRANT_STAT,
+       LDLM_POOL_CANCEL_STAT,
+       LDLM_POOL_GRANT_RATE_STAT,
+       LDLM_POOL_CANCEL_RATE_STAT,
+       LDLM_POOL_GRANT_PLAN_STAT,
+       LDLM_POOL_SLV_STAT,
+       LDLM_POOL_SHRINK_REQTD_STAT,
+       LDLM_POOL_SHRINK_FREED_STAT,
+       LDLM_POOL_RECALC_STAT,
+       LDLM_POOL_TIMING_STAT,
+       LDLM_POOL_LAST_STAT
+};
+
+/**
+ * Calculates suggested grant_step in % of available locks for passed
+ * @period. This is later used in grant_plan calculations.
+ */
+static inline int ldlm_pool_t2gsp(unsigned int t)
+{
+       /*
+        * This yields 1% grant step for anything below LDLM_POOL_GSP_STEP
+        * and up to 30% for anything higher than LDLM_POOL_GSP_STEP.
+        *
+        * How this will affect execution is the following:
+        *
+        * - for thread period 1s we will have grant_step 1% which good from
+        * pov of taking some load off from server and push it out to clients.
+        * This is like that because 1% for grant_step means that server will
+        * not allow clients to get lots of locks in short period of time and
+        * keep all old locks in their caches. Clients will always have to
+        * get some locks back if they want to take some new;
+        *
+        * - for thread period 10s (which is default) we will have 23% which
+        * means that clients will have enough of room to take some new locks
+        * without getting some back. All locks from this 23% which were not
+        * taken by clients in current period will contribute in SLV growing.
+        * SLV growing means more locks cached on clients until limit or grant
+        * plan is reached.
+        */
+       return LDLM_POOL_MAX_GSP -
+               ((LDLM_POOL_MAX_GSP - LDLM_POOL_MIN_GSP) >>
+                (t >> LDLM_POOL_GSP_STEP_SHIFT));
+}
+
+/**
+ * Recalculates next stats on passed @pl.
+ *
+ * \pre ->pl_lock is locked.
+ */
+static void ldlm_pool_recalc_stats(struct ldlm_pool *pl)
+{
+       int grant_plan = pl->pl_grant_plan;
+       u64 slv = pl->pl_server_lock_volume;
+       int granted = atomic_read(&pl->pl_granted);
+       int grant_rate = atomic_read(&pl->pl_grant_rate);
+       int cancel_rate = atomic_read(&pl->pl_cancel_rate);
+
+       lprocfs_counter_add(pl->pl_stats, LDLM_POOL_SLV_STAT,
+                           slv);
+       lprocfs_counter_add(pl->pl_stats, LDLM_POOL_GRANTED_STAT,
+                           granted);
+       lprocfs_counter_add(pl->pl_stats, LDLM_POOL_GRANT_RATE_STAT,
+                           grant_rate);
+       lprocfs_counter_add(pl->pl_stats, LDLM_POOL_GRANT_PLAN_STAT,
+                           grant_plan);
+       lprocfs_counter_add(pl->pl_stats, LDLM_POOL_CANCEL_RATE_STAT,
+                           cancel_rate);
+}
+
+/**
+ * Sets SLV and Limit from container_of(pl, struct ldlm_namespace,
+ * ns_pool)->ns_obd tp passed @pl.
+ */
+static void ldlm_cli_pool_pop_slv(struct ldlm_pool *pl)
+{
+       struct obd_device *obd;
+
+       /*
+        * Get new SLV and Limit from obd which is updated with coming
+        * RPCs.
+        */
+       obd = container_of(pl, struct ldlm_namespace,
+                          ns_pool)->ns_obd;
+       read_lock(&obd->obd_pool_lock);
+       pl->pl_server_lock_volume = obd->obd_pool_slv;
+       atomic_set(&pl->pl_limit, obd->obd_pool_limit);
+       read_unlock(&obd->obd_pool_lock);
+}
+
+/**
+ * Recalculates client size pool @pl according to current SLV and Limit.
+ */
+static int ldlm_cli_pool_recalc(struct ldlm_pool *pl)
+{
+       time64_t recalc_interval_sec;
+       int ret;
+
+       recalc_interval_sec = ktime_get_real_seconds() - pl->pl_recalc_time;
+       if (recalc_interval_sec < pl->pl_recalc_period)
+               return 0;
+
+       spin_lock(&pl->pl_lock);
+       /*
+        * Check if we need to recalc lists now.
+        */
+       recalc_interval_sec = ktime_get_real_seconds() - pl->pl_recalc_time;
+       if (recalc_interval_sec < pl->pl_recalc_period) {
+               spin_unlock(&pl->pl_lock);
+               return 0;
+       }
+
+       /*
+        * Make sure that pool knows last SLV and Limit from obd.
+        */
+       ldlm_cli_pool_pop_slv(pl);
+
+       spin_unlock(&pl->pl_lock);
+
+       /*
+        * In the time of canceling locks on client we do not need to maintain
+        * sharp timing, we only want to cancel locks asap according to new SLV.
+        * It may be called when SLV has changed much, this is why we do not
+        * take into account pl->pl_recalc_time here.
+        */
+       ret = ldlm_cancel_lru(container_of(pl, struct ldlm_namespace, ns_pool),
+                             0, LCF_ASYNC, 0);
+
+       spin_lock(&pl->pl_lock);
+       /*
+        * Time of LRU resizing might be longer than period,
+        * so update after LRU resizing rather than before it.
+        */
+       pl->pl_recalc_time = ktime_get_real_seconds();
+       lprocfs_counter_add(pl->pl_stats, LDLM_POOL_TIMING_STAT,
+                           recalc_interval_sec);
+       spin_unlock(&pl->pl_lock);
+       return ret;
+}
+
+/**
+ * This function is main entry point for memory pressure handling on client
+ * side.  Main goal of this function is to cancel some number of locks on
+ * passed @pl according to @nr and @gfp_mask.
+ */
+static int ldlm_cli_pool_shrink(struct ldlm_pool *pl,
+                               int nr, gfp_t gfp_mask)
+{
+       struct ldlm_namespace *ns;
+       int unused;
+
+       ns = container_of(pl, struct ldlm_namespace, ns_pool);
+
+       /*
+        * Do not cancel locks in case lru resize is disabled for this ns.
+        */
+       if (!ns_connect_lru_resize(ns))
+               return 0;
+
+       /*
+        * Make sure that pool knows last SLV and Limit from obd.
+        */
+       ldlm_cli_pool_pop_slv(pl);
+
+       spin_lock(&ns->ns_lock);
+       unused = ns->ns_nr_unused;
+       spin_unlock(&ns->ns_lock);
+
+       if (nr == 0)
+               return (unused / 100) * sysctl_vfs_cache_pressure;
+       else
+               return ldlm_cancel_lru(ns, nr, LCF_ASYNC, 0);
+}
+
+static const struct ldlm_pool_ops ldlm_cli_pool_ops = {
+       .po_recalc = ldlm_cli_pool_recalc,
+       .po_shrink = ldlm_cli_pool_shrink
+};
+
+/**
+ * Pool recalc wrapper. Will call either client or server pool recalc callback
+ * depending what pool @pl is used.
+ */
+static int ldlm_pool_recalc(struct ldlm_pool *pl)
+{
+       u32 recalc_interval_sec;
+       int count;
+
+       recalc_interval_sec = ktime_get_real_seconds() - pl->pl_recalc_time;
+       if (recalc_interval_sec > 0) {
+               spin_lock(&pl->pl_lock);
+               recalc_interval_sec = ktime_get_real_seconds() -
+                                     pl->pl_recalc_time;
+
+               if (recalc_interval_sec > 0) {
+                       /*
+                        * Update pool statistics every 1s.
+                        */
+                       ldlm_pool_recalc_stats(pl);
+
+                       /*
+                        * Zero out all rates and speed for the last period.
+                        */
+                       atomic_set(&pl->pl_grant_rate, 0);
+                       atomic_set(&pl->pl_cancel_rate, 0);
+               }
+               spin_unlock(&pl->pl_lock);
+       }
+
+       if (pl->pl_ops->po_recalc) {
+               count = pl->pl_ops->po_recalc(pl);
+               lprocfs_counter_add(pl->pl_stats, LDLM_POOL_RECALC_STAT,
+                                   count);
+       }
+
+       recalc_interval_sec = pl->pl_recalc_time - ktime_get_real_seconds() +
+                             pl->pl_recalc_period;
+       if (recalc_interval_sec <= 0) {
+               /* DEBUG: should be re-removed after LU-4536 is fixed */
+               CDEBUG(D_DLMTRACE,
+                      "%s: Negative interval(%ld), too short period(%ld)\n",
+                      pl->pl_name, (long)recalc_interval_sec,
+                      (long)pl->pl_recalc_period);
+
+               /* Prevent too frequent recalculation. */
+               recalc_interval_sec = 1;
+       }
+
+       return recalc_interval_sec;
+}
+
+/*
+ * Pool shrink wrapper. Will call either client or server pool recalc callback
+ * depending what pool pl is used. When nr == 0, just return the number of
+ * freeable locks. Otherwise, return the number of canceled locks.
+ */
+static int ldlm_pool_shrink(struct ldlm_pool *pl, int nr, gfp_t gfp_mask)
+{
+       int cancel = 0;
+
+       if (pl->pl_ops->po_shrink) {
+               cancel = pl->pl_ops->po_shrink(pl, nr, gfp_mask);
+               if (nr > 0) {
+                       lprocfs_counter_add(pl->pl_stats,
+                                           LDLM_POOL_SHRINK_REQTD_STAT,
+                                           nr);
+                       lprocfs_counter_add(pl->pl_stats,
+                                           LDLM_POOL_SHRINK_FREED_STAT,
+                                           cancel);
+                       CDEBUG(D_DLMTRACE,
+                              "%s: request to shrink %d locks, shrunk %d\n",
+                              pl->pl_name, nr, cancel);
+               }
+       }
+       return cancel;
+}
+
+static int lprocfs_pool_state_seq_show(struct seq_file *m, void *unused)
+{
+       int granted, grant_rate, cancel_rate;
+       int grant_speed, lvf;
+       struct ldlm_pool *pl = m->private;
+       u64 slv, clv;
+       u32 limit;
+
+       spin_lock(&pl->pl_lock);
+       slv = pl->pl_server_lock_volume;
+       clv = pl->pl_client_lock_volume;
+       limit = atomic_read(&pl->pl_limit);
+       granted = atomic_read(&pl->pl_granted);
+       grant_rate = atomic_read(&pl->pl_grant_rate);
+       cancel_rate = atomic_read(&pl->pl_cancel_rate);
+       grant_speed = grant_rate - cancel_rate;
+       lvf = atomic_read(&pl->pl_lock_volume_factor);
+       spin_unlock(&pl->pl_lock);
+
+       seq_printf(m, "LDLM pool state (%s):\n"
+                     "  SLV: %llu\n"
+                     "  CLV: %llu\n"
+                     "  LVF: %d\n",
+                     pl->pl_name, slv, clv, lvf);
+
+       seq_printf(m, "  GR:  %d\n  CR:  %d\n  GS:  %d\n"
+                     "  G:   %d\n  L:   %d\n",
+                     grant_rate, cancel_rate, grant_speed,
+                     granted, limit);
+
+       return 0;
+}
+
+LDEBUGFS_SEQ_FOPS_RO(lprocfs_pool_state);
+
+static ssize_t grant_speed_show(struct kobject *kobj, struct attribute *attr,
+                               char *buf)
+{
+       struct ldlm_pool *pl = container_of(kobj, struct ldlm_pool,
+                                           pl_kobj);
+       int grant_speed;
+
+       spin_lock(&pl->pl_lock);
+       /* serialize with ldlm_pool_recalc */
+       grant_speed = atomic_read(&pl->pl_grant_rate) -
+                       atomic_read(&pl->pl_cancel_rate);
+       spin_unlock(&pl->pl_lock);
+       return sprintf(buf, "%d\n", grant_speed);
+}
+LUSTRE_RO_ATTR(grant_speed);
+
+LDLM_POOL_SYSFS_READER_SHOW(grant_plan, int);
+LUSTRE_RO_ATTR(grant_plan);
+
+LDLM_POOL_SYSFS_READER_SHOW(recalc_period, int);
+LDLM_POOL_SYSFS_WRITER_STORE(recalc_period, int);
+LUSTRE_RW_ATTR(recalc_period);
+
+LDLM_POOL_SYSFS_READER_NOLOCK_SHOW(server_lock_volume, u64);
+LUSTRE_RO_ATTR(server_lock_volume);
+
+LDLM_POOL_SYSFS_READER_NOLOCK_SHOW(limit, atomic);
+LDLM_POOL_SYSFS_WRITER_NOLOCK_STORE(limit, atomic);
+LUSTRE_RW_ATTR(limit);
+
+LDLM_POOL_SYSFS_READER_NOLOCK_SHOW(granted, atomic);
+LUSTRE_RO_ATTR(granted);
+
+LDLM_POOL_SYSFS_READER_NOLOCK_SHOW(cancel_rate, atomic);
+LUSTRE_RO_ATTR(cancel_rate);
+
+LDLM_POOL_SYSFS_READER_NOLOCK_SHOW(grant_rate, atomic);
+LUSTRE_RO_ATTR(grant_rate);
+
+LDLM_POOL_SYSFS_READER_NOLOCK_SHOW(lock_volume_factor, atomic);
+LDLM_POOL_SYSFS_WRITER_NOLOCK_STORE(lock_volume_factor, atomic);
+LUSTRE_RW_ATTR(lock_volume_factor);
+
+/* These are for pools in /sys/fs/lustre/ldlm/namespaces/.../pool */
+static struct attribute *ldlm_pl_attrs[] = {
+       &lustre_attr_grant_speed.attr,
+       &lustre_attr_grant_plan.attr,
+       &lustre_attr_recalc_period.attr,
+       &lustre_attr_server_lock_volume.attr,
+       &lustre_attr_limit.attr,
+       &lustre_attr_granted.attr,
+       &lustre_attr_cancel_rate.attr,
+       &lustre_attr_grant_rate.attr,
+       &lustre_attr_lock_volume_factor.attr,
+       NULL,
+};
+
+static void ldlm_pl_release(struct kobject *kobj)
+{
+       struct ldlm_pool *pl = container_of(kobj, struct ldlm_pool,
+                                           pl_kobj);
+       complete(&pl->pl_kobj_unregister);
+}
+
+static struct kobj_type ldlm_pl_ktype = {
+       .default_attrs  = ldlm_pl_attrs,
+       .sysfs_ops      = &lustre_sysfs_ops,
+       .release        = ldlm_pl_release,
+};
+
+static int ldlm_pool_sysfs_init(struct ldlm_pool *pl)
+{
+       struct ldlm_namespace *ns = container_of(pl, struct ldlm_namespace,
+                                                ns_pool);
+       int err;
+
+       init_completion(&pl->pl_kobj_unregister);
+       err = kobject_init_and_add(&pl->pl_kobj, &ldlm_pl_ktype, &ns->ns_kobj,
+                                  "pool");
+
+       return err;
+}
+
+static int ldlm_pool_debugfs_init(struct ldlm_pool *pl)
+{
+       struct ldlm_namespace *ns = container_of(pl, struct ldlm_namespace,
+                                                ns_pool);
+       struct dentry *debugfs_ns_parent;
+       struct ldebugfs_vars pool_vars[2];
+       int rc = 0;
+
+       debugfs_ns_parent = ns->ns_debugfs_entry;
+       if (IS_ERR_OR_NULL(debugfs_ns_parent)) {
+               CERROR("%s: debugfs entry is not initialized\n",
+                      ldlm_ns_name(ns));
+               rc = -EINVAL;
+               goto out;
+       }
+       pl->pl_debugfs_entry = debugfs_create_dir("pool", debugfs_ns_parent);
+
+       memset(pool_vars, 0, sizeof(pool_vars));
+
+       ldlm_add_var(&pool_vars[0], pl->pl_debugfs_entry, "state", pl,
+                    &lprocfs_pool_state_fops);
+
+       pl->pl_stats = lprocfs_alloc_stats(LDLM_POOL_LAST_STAT -
+                                          LDLM_POOL_FIRST_STAT, 0);
+       if (!pl->pl_stats) {
+               rc = -ENOMEM;
+               goto out;
+       }
+
+       lprocfs_counter_init(pl->pl_stats, LDLM_POOL_GRANTED_STAT,
+                            LPROCFS_CNTR_AVGMINMAX | LPROCFS_CNTR_STDDEV,
+                            "granted", "locks");
+       lprocfs_counter_init(pl->pl_stats, LDLM_POOL_GRANT_STAT,
+                            LPROCFS_CNTR_AVGMINMAX | LPROCFS_CNTR_STDDEV,
+                            "grant", "locks");
+       lprocfs_counter_init(pl->pl_stats, LDLM_POOL_CANCEL_STAT,
+                            LPROCFS_CNTR_AVGMINMAX | LPROCFS_CNTR_STDDEV,
+                            "cancel", "locks");
+       lprocfs_counter_init(pl->pl_stats, LDLM_POOL_GRANT_RATE_STAT,
+                            LPROCFS_CNTR_AVGMINMAX | LPROCFS_CNTR_STDDEV,
+                            "grant_rate", "locks/s");
+       lprocfs_counter_init(pl->pl_stats, LDLM_POOL_CANCEL_RATE_STAT,
+                            LPROCFS_CNTR_AVGMINMAX | LPROCFS_CNTR_STDDEV,
+                            "cancel_rate", "locks/s");
+       lprocfs_counter_init(pl->pl_stats, LDLM_POOL_GRANT_PLAN_STAT,
+                            LPROCFS_CNTR_AVGMINMAX | LPROCFS_CNTR_STDDEV,
+                            "grant_plan", "locks/s");
+       lprocfs_counter_init(pl->pl_stats, LDLM_POOL_SLV_STAT,
+                            LPROCFS_CNTR_AVGMINMAX | LPROCFS_CNTR_STDDEV,
+                            "slv", "slv");
+       lprocfs_counter_init(pl->pl_stats, LDLM_POOL_SHRINK_REQTD_STAT,
+                            LPROCFS_CNTR_AVGMINMAX | LPROCFS_CNTR_STDDEV,
+                            "shrink_request", "locks");
+       lprocfs_counter_init(pl->pl_stats, LDLM_POOL_SHRINK_FREED_STAT,
+                            LPROCFS_CNTR_AVGMINMAX | LPROCFS_CNTR_STDDEV,
+                            "shrink_freed", "locks");
+       lprocfs_counter_init(pl->pl_stats, LDLM_POOL_RECALC_STAT,
+                            LPROCFS_CNTR_AVGMINMAX | LPROCFS_CNTR_STDDEV,
+                            "recalc_freed", "locks");
+       lprocfs_counter_init(pl->pl_stats, LDLM_POOL_TIMING_STAT,
+                            LPROCFS_CNTR_AVGMINMAX | LPROCFS_CNTR_STDDEV,
+                            "recalc_timing", "sec");
+       debugfs_create_file("stats", 0644, pl->pl_debugfs_entry, pl->pl_stats,
+                           &ldebugfs_stats_seq_fops);
+
+out:
+       return rc;
+}
+
+static void ldlm_pool_sysfs_fini(struct ldlm_pool *pl)
+{
+       kobject_put(&pl->pl_kobj);
+       wait_for_completion(&pl->pl_kobj_unregister);
+}
+
+static void ldlm_pool_debugfs_fini(struct ldlm_pool *pl)
+{
+       if (pl->pl_stats) {
+               lprocfs_free_stats(&pl->pl_stats);
+               pl->pl_stats = NULL;
+       }
+       debugfs_remove_recursive(pl->pl_debugfs_entry);
+}
+
+int ldlm_pool_init(struct ldlm_pool *pl, struct ldlm_namespace *ns,
+                  int idx, enum ldlm_side client)
+{
+       int rc;
+
+       spin_lock_init(&pl->pl_lock);
+       atomic_set(&pl->pl_granted, 0);
+       pl->pl_recalc_time = ktime_get_real_seconds();
+       atomic_set(&pl->pl_lock_volume_factor, 1);
+
+       atomic_set(&pl->pl_grant_rate, 0);
+       atomic_set(&pl->pl_cancel_rate, 0);
+       pl->pl_grant_plan = LDLM_POOL_GP(LDLM_POOL_HOST_L);
+
+       snprintf(pl->pl_name, sizeof(pl->pl_name), "ldlm-pool-%s-%d",
+                ldlm_ns_name(ns), idx);
+
+       atomic_set(&pl->pl_limit, 1);
+       pl->pl_server_lock_volume = 0;
+       pl->pl_ops = &ldlm_cli_pool_ops;
+       pl->pl_recalc_period = LDLM_POOL_CLI_DEF_RECALC_PERIOD;
+       pl->pl_client_lock_volume = 0;
+       rc = ldlm_pool_debugfs_init(pl);
+       if (rc)
+               return rc;
+
+       rc = ldlm_pool_sysfs_init(pl);
+       if (rc)
+               return rc;
+
+       CDEBUG(D_DLMTRACE, "Lock pool %s is initialized\n", pl->pl_name);
+
+       return rc;
+}
+
+void ldlm_pool_fini(struct ldlm_pool *pl)
+{
+       ldlm_pool_sysfs_fini(pl);
+       ldlm_pool_debugfs_fini(pl);
+
+       /*
+        * Pool should not be used after this point. We can't free it here as
+        * it lives in struct ldlm_namespace, but still interested in catching
+        * any abnormal using cases.
+        */
+       POISON(pl, 0x5a, sizeof(*pl));
+}
+
+/**
+ * Add new taken ldlm lock @lock into pool @pl accounting.
+ */
+void ldlm_pool_add(struct ldlm_pool *pl, struct ldlm_lock *lock)
+{
+       /*
+        * FLOCK locks are special in a sense that they are almost never
+        * cancelled, instead special kind of lock is used to drop them.
+        * also there is no LRU for flock locks, so no point in tracking
+        * them anyway.
+        */
+       if (lock->l_resource->lr_type == LDLM_FLOCK)
+               return;
+
+       atomic_inc(&pl->pl_granted);
+       atomic_inc(&pl->pl_grant_rate);
+       lprocfs_counter_incr(pl->pl_stats, LDLM_POOL_GRANT_STAT);
+       /*
+        * Do not do pool recalc for client side as all locks which
+        * potentially may be canceled has already been packed into
+        * enqueue/cancel rpc. Also we do not want to run out of stack
+        * with too long call paths.
+        */
+}
+
+/**
+ * Remove ldlm lock @lock from pool @pl accounting.
+ */
+void ldlm_pool_del(struct ldlm_pool *pl, struct ldlm_lock *lock)
+{
+       /*
+        * Filter out FLOCK locks. Read above comment in ldlm_pool_add().
+        */
+       if (lock->l_resource->lr_type == LDLM_FLOCK)
+               return;
+
+       LASSERT(atomic_read(&pl->pl_granted) > 0);
+       atomic_dec(&pl->pl_granted);
+       atomic_inc(&pl->pl_cancel_rate);
+
+       lprocfs_counter_incr(pl->pl_stats, LDLM_POOL_CANCEL_STAT);
+}
+
+/**
+ * Returns current @pl SLV.
+ *
+ * \pre ->pl_lock is not locked.
+ */
+u64 ldlm_pool_get_slv(struct ldlm_pool *pl)
+{
+       u64 slv;
+
+       spin_lock(&pl->pl_lock);
+       slv = pl->pl_server_lock_volume;
+       spin_unlock(&pl->pl_lock);
+       return slv;
+}
+
+/**
+ * Sets passed @clv to @pl.
+ *
+ * \pre ->pl_lock is not locked.
+ */
+void ldlm_pool_set_clv(struct ldlm_pool *pl, u64 clv)
+{
+       spin_lock(&pl->pl_lock);
+       pl->pl_client_lock_volume = clv;
+       spin_unlock(&pl->pl_lock);
+}
+
+/**
+ * Returns current LVF from @pl.
+ */
+u32 ldlm_pool_get_lvf(struct ldlm_pool *pl)
+{
+       return atomic_read(&pl->pl_lock_volume_factor);
+}
+
+static int ldlm_pool_granted(struct ldlm_pool *pl)
+{
+       return atomic_read(&pl->pl_granted);
+}
+
+/*
+ * count locks from all namespaces (if possible). Returns number of
+ * cached locks.
+ */
+static unsigned long ldlm_pools_count(enum ldlm_side client, gfp_t gfp_mask)
+{
+       unsigned long total = 0;
+       int nr_ns;
+       struct ldlm_namespace *ns;
+       struct ldlm_namespace *ns_old = NULL; /* loop detection */
+
+       if (client == LDLM_NAMESPACE_CLIENT && !(gfp_mask & __GFP_FS))
+               return 0;
+
+       /*
+        * Find out how many resources we may release.
+        */
+       for (nr_ns = ldlm_namespace_nr_read(client);
+            nr_ns > 0; nr_ns--) {
+               mutex_lock(ldlm_namespace_lock(client));
+               if (list_empty(ldlm_namespace_list(client))) {
+                       mutex_unlock(ldlm_namespace_lock(client));
+                       return 0;
+               }
+               ns = ldlm_namespace_first_locked(client);
+
+               if (ns == ns_old) {
+                       mutex_unlock(ldlm_namespace_lock(client));
+                       break;
+               }
+
+               if (ldlm_ns_empty(ns)) {
+                       ldlm_namespace_move_to_inactive_locked(ns, client);
+                       mutex_unlock(ldlm_namespace_lock(client));
+                       continue;
+               }
+
+               if (!ns_old)
+                       ns_old = ns;
+
+               ldlm_namespace_get(ns);
+               ldlm_namespace_move_to_active_locked(ns, client);
+               mutex_unlock(ldlm_namespace_lock(client));
+               total += ldlm_pool_shrink(&ns->ns_pool, 0, gfp_mask);
+               ldlm_namespace_put(ns);
+       }
+
+       return total;
+}
+
+static unsigned long ldlm_pools_scan(enum ldlm_side client, int nr,
+                                    gfp_t gfp_mask)
+{
+       unsigned long freed = 0;
+       int tmp, nr_ns;
+       struct ldlm_namespace *ns;
+
+       if (client == LDLM_NAMESPACE_CLIENT && !(gfp_mask & __GFP_FS))
+               return -1;
+
+       /*
+        * Shrink at least ldlm_namespace_nr_read(client) namespaces.
+        */
+       for (tmp = nr_ns = ldlm_namespace_nr_read(client);
+            tmp > 0; tmp--) {
+               int cancel, nr_locks;
+
+               /*
+                * Do not call shrink under ldlm_namespace_lock(client)
+                */
+               mutex_lock(ldlm_namespace_lock(client));
+               if (list_empty(ldlm_namespace_list(client))) {
+                       mutex_unlock(ldlm_namespace_lock(client));
+                       break;
+               }
+               ns = ldlm_namespace_first_locked(client);
+               ldlm_namespace_get(ns);
+               ldlm_namespace_move_to_active_locked(ns, client);
+               mutex_unlock(ldlm_namespace_lock(client));
+
+               nr_locks = ldlm_pool_granted(&ns->ns_pool);
+               /*
+                * We use to shrink propotionally but with new shrinker API,
+                * we lost the total number of freeable locks.
+                */
+               cancel = 1 + min_t(int, nr_locks, nr / nr_ns);
+               freed += ldlm_pool_shrink(&ns->ns_pool, cancel, gfp_mask);
+               ldlm_namespace_put(ns);
+       }
+       /*
+        * we only decrease the SLV in server pools shrinker, return
+        * SHRINK_STOP to kernel to avoid needless loop. LU-1128
+        */
+       return freed;
+}
+
+static unsigned long ldlm_pools_cli_count(struct shrinker *s,
+                                         struct shrink_control *sc)
+{
+       return ldlm_pools_count(LDLM_NAMESPACE_CLIENT, sc->gfp_mask);
+}
+
+static unsigned long ldlm_pools_cli_scan(struct shrinker *s,
+                                        struct shrink_control *sc)
+{
+       return ldlm_pools_scan(LDLM_NAMESPACE_CLIENT, sc->nr_to_scan,
+                              sc->gfp_mask);
+}
+
+static void ldlm_pools_recalc(struct work_struct *ws);
+static DECLARE_DELAYED_WORK(ldlm_recalc_pools, ldlm_pools_recalc);
+
+static void ldlm_pools_recalc(struct work_struct *ws)
+{
+       enum ldlm_side client = LDLM_NAMESPACE_CLIENT;
+       struct ldlm_namespace *ns;
+       struct ldlm_namespace *ns_old = NULL;
+       /* seconds of sleep if no active namespaces */
+       time64_t time = LDLM_POOL_CLI_DEF_RECALC_PERIOD;
+       int nr;
+
+       /*
+        * Recalc at least ldlm_namespace_nr_read(client) namespaces.
+        */
+       for (nr = ldlm_namespace_nr_read(client); nr > 0; nr--) {
+               int skip;
+               /*
+                * Lock the list, get first @ns in the list, getref, move it
+                * to the tail, unlock and call pool recalc. This way we avoid
+                * calling recalc under @ns lock what is really good as we get
+                * rid of potential deadlock on client nodes when canceling
+                * locks synchronously.
+                */
+               mutex_lock(ldlm_namespace_lock(client));
+               if (list_empty(ldlm_namespace_list(client))) {
+                       mutex_unlock(ldlm_namespace_lock(client));
+                       break;
+               }
+               ns = ldlm_namespace_first_locked(client);
+
+               if (ns_old == ns) { /* Full pass complete */
+                       mutex_unlock(ldlm_namespace_lock(client));
+                       break;
+               }
+
+               /* We got an empty namespace, need to move it back to inactive
+                * list.
+                * The race with parallel resource creation is fine:
+                * - If they do namespace_get before our check, we fail the
+                *   check and they move this item to the end of the list anyway
+                * - If we do the check and then they do namespace_get, then
+                *   we move the namespace to inactive and they will move
+                *   it back to active (synchronised by the lock, so no clash
+                *   there).
+                */
+               if (ldlm_ns_empty(ns)) {
+                       ldlm_namespace_move_to_inactive_locked(ns, client);
+                       mutex_unlock(ldlm_namespace_lock(client));
+                       continue;
+               }
+
+               if (!ns_old)
+                       ns_old = ns;
+
+               spin_lock(&ns->ns_lock);
+               /*
+                * skip ns which is being freed, and we don't want to increase
+                * its refcount again, not even temporarily. bz21519 & LU-499.
+                */
+               if (ns->ns_stopping) {
+                       skip = 1;
+               } else {
+                       skip = 0;
+                       ldlm_namespace_get(ns);
+               }
+               spin_unlock(&ns->ns_lock);
+
+               ldlm_namespace_move_to_active_locked(ns, client);
+               mutex_unlock(ldlm_namespace_lock(client));
+
+               /*
+                * After setup is done - recalc the pool.
+                */
+               if (!skip) {
+                       time64_t ttime = ldlm_pool_recalc(&ns->ns_pool);
+
+                       if (ttime < time)
+                               time = ttime;
+
+                       ldlm_namespace_put(ns);
+               }
+       }
+
+       /* Wake up the blocking threads from time to time. */
+       ldlm_bl_thread_wakeup();
+
+       schedule_delayed_work(&ldlm_recalc_pools, time * HZ);
+}
+
+static int ldlm_pools_thread_start(void)
+{
+       schedule_delayed_work(&ldlm_recalc_pools, 0);
+
+       return 0;
+}
+
+static void ldlm_pools_thread_stop(void)
+{
+       cancel_delayed_work_sync(&ldlm_recalc_pools);
+}
+
+static struct shrinker ldlm_pools_cli_shrinker = {
+       .count_objects  = ldlm_pools_cli_count,
+       .scan_objects   = ldlm_pools_cli_scan,
+       .seeks          = DEFAULT_SEEKS,
+};
+
+int ldlm_pools_init(void)
+{
+       int rc;
+
+       rc = ldlm_pools_thread_start();
+       if (!rc)
+               rc = register_shrinker(&ldlm_pools_cli_shrinker);
+
+       return rc;
+}
+
+void ldlm_pools_fini(void)
+{
+       unregister_shrinker(&ldlm_pools_cli_shrinker);
+
+       ldlm_pools_thread_stop();
+}
diff --git a/tests/lustre/pool/patch b/tests/lustre/pool/patch
new file mode 100644 (file)
index 0000000..fea95bd
--- /dev/null
@@ -0,0 +1,326 @@
+diff --git a/fs/lustre/ldlm/ldlm_pool.c b/fs/lustre/ldlm/ldlm_pool.c
+index b6d64f0f26f8..8eb29c4147f7 100644
+--- a/fs/lustre/ldlm/ldlm_pool.c
++++ b/fs/lustre/ldlm/ldlm_pool.c
+@@ -286,13 +286,13 @@ static void ldlm_pool_recalc_slv(struct ldlm_pool *pl)
+  *
+  * \pre ->pl_lock is locked.
+  */
+-static void ldlm_pool_recalc_stats(struct ldlm_pool *pl)
++static void ldlm_pool_recalc_stats(struct ldlm_pool *pl, timeout_t period)
+ {
+       int grant_plan = pl->pl_grant_plan;
+       __u64 slv = pl->pl_server_lock_volume;
+       int granted = ldlm_pool_granted(pl);
+-      int grant_rate = atomic_read(&pl->pl_grant_rate);
+-      int cancel_rate = atomic_read(&pl->pl_cancel_rate);
++      int grant_rate = atomic_read(&pl->pl_grant_rate) / period;
++      int cancel_rate = atomic_read(&pl->pl_cancel_rate) / period;
+       lprocfs_counter_add(pl->pl_stats, LDLM_POOL_SLV_STAT,
+                           slv);
+@@ -334,16 +334,16 @@ static void ldlm_srv_pool_push_slv(struct ldlm_pool *pl)
+  */
+ static int ldlm_srv_pool_recalc(struct ldlm_pool *pl)
+ {
+-      time64_t recalc_interval_sec;
++      timeout_t recalc_interval_sec;
+       ENTRY;
+-      recalc_interval_sec = ktime_get_real_seconds() - pl->pl_recalc_time;
++      recalc_interval_sec = ktime_get_seconds() - pl->pl_recalc_time;
+       if (recalc_interval_sec < pl->pl_recalc_period)
+               return 0;
+       spin_lock(&pl->pl_lock);
+-      recalc_interval_sec = ktime_get_real_seconds() - pl->pl_recalc_time;
++      recalc_interval_sec = ktime_get_seconds() - pl->pl_recalc_time;
+       if (recalc_interval_sec < pl->pl_recalc_period) {
+               spin_unlock(&pl->pl_lock);
+               return 0;
+@@ -364,7 +364,7 @@ static int ldlm_srv_pool_recalc(struct ldlm_pool *pl)
+        */
+       ldlm_pool_recalc_grant_plan(pl);
+-      pl->pl_recalc_time = ktime_get_real_seconds();
++      pl->pl_recalc_time = ktime_get_seconds();
+       lprocfs_counter_add(pl->pl_stats, LDLM_POOL_TIMING_STAT,
+                           recalc_interval_sec);
+       spin_unlock(&pl->pl_lock);
+@@ -473,12 +473,12 @@ static void ldlm_cli_pool_pop_slv(struct ldlm_pool *pl)
+  */
+ static int ldlm_cli_pool_recalc(struct ldlm_pool *pl)
+ {
+-      time64_t recalc_interval_sec;
++      timeout_t recalc_interval_sec;
+       int ret;
+       ENTRY;
+-      recalc_interval_sec = ktime_get_real_seconds() - pl->pl_recalc_time;
++      recalc_interval_sec = ktime_get_seconds() - pl->pl_recalc_time;
+       if (recalc_interval_sec < pl->pl_recalc_period)
+               return 0;
+@@ -486,7 +486,7 @@ static int ldlm_cli_pool_recalc(struct ldlm_pool *pl)
+       /*
+        * Check if we need to recalc lists now.
+        */
+-      recalc_interval_sec = ktime_get_real_seconds() - pl->pl_recalc_time;
++      recalc_interval_sec = ktime_get_seconds() - pl->pl_recalc_time;
+       if (recalc_interval_sec < pl->pl_recalc_period) {
+               spin_unlock(&pl->pl_lock);
+               return 0;
+@@ -511,7 +511,7 @@ static int ldlm_cli_pool_recalc(struct ldlm_pool *pl)
+        * Time of LRU resizing might be longer than period,
+        * so update after LRU resizing rather than before it.
+        */
+-      pl->pl_recalc_time = ktime_get_real_seconds();
++      pl->pl_recalc_time = ktime_get_seconds();
+       lprocfs_counter_add(pl->pl_stats, LDLM_POOL_TIMING_STAT,
+                           recalc_interval_sec);
+       spin_unlock(&pl->pl_lock);
+@@ -540,7 +540,9 @@ static int ldlm_cli_pool_shrink(struct ldlm_pool *pl,
+       /*
+        * Make sure that pool knows last SLV and Limit from obd.
+        */
++      spin_lock(&pl->pl_lock);
+       ldlm_cli_pool_pop_slv(pl);
++      spin_unlock(&pl->pl_lock);
+       spin_lock(&ns->ns_lock);
+       unused = ns->ns_nr_unused;
+@@ -566,23 +568,24 @@ static struct ldlm_pool_ops ldlm_cli_pool_ops = {
+ /**
+  * Pool recalc wrapper. Will call either client or server pool recalc callback
+  * depending what pool \a pl is used.
++ *
++ * \retval            time in seconds for the next recalc of this pool
+  */
+ time64_t ldlm_pool_recalc(struct ldlm_pool *pl)
+ {
+-      time64_t recalc_interval_sec;
++      timeout_t recalc_interval_sec;
+       int count;
+-      recalc_interval_sec = ktime_get_real_seconds() - pl->pl_recalc_time;
++      recalc_interval_sec = ktime_get_seconds() - pl->pl_recalc_time;
+       if (recalc_interval_sec > 0) {
+               spin_lock(&pl->pl_lock);
+-              recalc_interval_sec = ktime_get_real_seconds() -
+-                      pl->pl_recalc_time;
++              recalc_interval_sec = ktime_get_seconds() - pl->pl_recalc_time;
+               if (recalc_interval_sec > 0) {
+                       /*
+-                       * Update pool statistics every 1s.
++                       * Update pool statistics every recalc interval.
+                        */
+-                      ldlm_pool_recalc_stats(pl);
++                      ldlm_pool_recalc_stats(pl, recalc_interval_sec);
+                       /*
+                        * Zero out all rates and speed for the last period.
+@@ -599,19 +602,7 @@ time64_t ldlm_pool_recalc(struct ldlm_pool *pl)
+                                   count);
+       }
+-      recalc_interval_sec = pl->pl_recalc_time - ktime_get_real_seconds() +
+-                            pl->pl_recalc_period;
+-      if (recalc_interval_sec <= 0) {
+-              /* DEBUG: should be re-removed after LU-4536 is fixed */
+-              CDEBUG(D_DLMTRACE, "%s: Negative interval(%lld), too short period(%lld)\n",
+-                     pl->pl_name, recalc_interval_sec,
+-                     (s64)pl->pl_recalc_period);
+-
+-              /* Prevent too frequent recalculation. */
+-              recalc_interval_sec = 1;
+-      }
+-
+-      return recalc_interval_sec;
++      return pl->pl_recalc_time + pl->pl_recalc_period;
+ }
+ /**
+@@ -657,6 +648,7 @@ static int lprocfs_pool_state_seq_show(struct seq_file *m, void *unused)
+       int granted, grant_rate, cancel_rate, grant_step;
+       int grant_speed, grant_plan, lvf;
+       struct ldlm_pool *pl = m->private;
++      timeout_t period;
+       __u64 slv, clv;
+       __u32 limit;
+@@ -666,8 +658,11 @@ static int lprocfs_pool_state_seq_show(struct seq_file *m, void *unused)
+       limit = ldlm_pool_get_limit(pl);
+       grant_plan = pl->pl_grant_plan;
+       granted = ldlm_pool_granted(pl);
+-      grant_rate = atomic_read(&pl->pl_grant_rate);
+-      cancel_rate = atomic_read(&pl->pl_cancel_rate);
++      period = ktime_get_seconds() - pl->pl_recalc_time;
++      if (period <= 0)
++              period = 1;
++      grant_rate = atomic_read(&pl->pl_grant_rate) / period;
++      cancel_rate = atomic_read(&pl->pl_cancel_rate) / period;
+       grant_speed = grant_rate - cancel_rate;
+       lvf = atomic_read(&pl->pl_lock_volume_factor);
+       grant_step = ldlm_pool_t2gsp(pl->pl_recalc_period);
+@@ -677,7 +672,7 @@ static int lprocfs_pool_state_seq_show(struct seq_file *m, void *unused)
+                  "  SLV: %llu\n"
+                  "  CLV: %llu\n"
+                  "  LVF: %d\n",
+-                 pl->pl_name, slv, clv, lvf);
++                 pl->pl_name, slv, clv, (lvf * 100) >> 8);
+       if (ns_is_server(ldlm_pl2ns(pl))) {
+               seq_printf(m, "  GSP: %d%%\n", grant_step);
+@@ -698,11 +693,15 @@ static ssize_t grant_speed_show(struct kobject *kobj, struct attribute *attr,
+       struct ldlm_pool *pl = container_of(kobj, struct ldlm_pool,
+                                           pl_kobj);
+       int grant_speed;
++      timeout_t period;
+       spin_lock(&pl->pl_lock);
+       /* serialize with ldlm_pool_recalc */
+-      grant_speed = atomic_read(&pl->pl_grant_rate) -
+-                      atomic_read(&pl->pl_cancel_rate);
++      period = ktime_get_seconds() - pl->pl_recalc_time;
++      if (period <= 0)
++              period = 1;
++      grant_speed = (atomic_read(&pl->pl_grant_rate) -
++                     atomic_read(&pl->pl_cancel_rate)) / period;
+       spin_unlock(&pl->pl_lock);
+       return sprintf(buf, "%d\n", grant_speed);
+ }
+@@ -718,6 +717,9 @@ LUSTRE_RW_ATTR(recalc_period);
+ LDLM_POOL_SYSFS_READER_NOLOCK_SHOW(server_lock_volume, u64);
+ LUSTRE_RO_ATTR(server_lock_volume);
++LDLM_POOL_SYSFS_READER_NOLOCK_SHOW(client_lock_volume, u64);
++LUSTRE_RO_ATTR(client_lock_volume);
++
+ LDLM_POOL_SYSFS_READER_NOLOCK_SHOW(limit, atomic);
+ LDLM_POOL_SYSFS_WRITER_NOLOCK_STORE(limit, atomic);
+ LUSTRE_RW_ATTR(limit);
+@@ -731,16 +733,58 @@ LUSTRE_RO_ATTR(cancel_rate);
+ LDLM_POOL_SYSFS_READER_NOLOCK_SHOW(grant_rate, atomic);
+ LUSTRE_RO_ATTR(grant_rate);
+-LDLM_POOL_SYSFS_READER_NOLOCK_SHOW(lock_volume_factor, atomic);
+-LDLM_POOL_SYSFS_WRITER_NOLOCK_STORE(lock_volume_factor, atomic);
++static ssize_t lock_volume_factor_show(struct kobject *kobj,
++                                     struct attribute *attr,
++                                     char *buf)
++{
++      struct ldlm_pool *pl = container_of(kobj, struct ldlm_pool, pl_kobj);
++      unsigned long tmp;
++
++      tmp = (atomic_read(&pl->pl_lock_volume_factor) * 100) >> 8;
++      return sprintf(buf, "%lu\n", tmp);
++}
++
++static ssize_t lock_volume_factor_store(struct kobject *kobj,
++                                      struct attribute *attr,
++                                      const char *buffer,
++                                      size_t count)
++{
++      struct ldlm_pool *pl = container_of(kobj, struct ldlm_pool, pl_kobj);
++      unsigned long tmp;
++      int rc;
++
++      rc = kstrtoul(buffer, 10, &tmp);
++      if (rc < 0) {
++              return rc;
++      }
++
++      tmp = (tmp << 8) / 100;
++      atomic_set(&pl->pl_lock_volume_factor, tmp);
++
++      return count;
++
++}
+ LUSTRE_RW_ATTR(lock_volume_factor);
++static ssize_t recalc_time_show(struct kobject *kobj,
++                              struct attribute *attr,
++                              char *buf)
++{
++      struct ldlm_pool *pl = container_of(kobj, struct ldlm_pool, pl_kobj);
++
++      return snprintf(buf, PAGE_SIZE, "%llu\n",
++                      ktime_get_seconds() - pl->pl_recalc_time);
++}
++LUSTRE_RO_ATTR(recalc_time);
++
+ /* These are for pools in /sys/fs/lustre/ldlm/namespaces/.../pool */
+ static struct attribute *ldlm_pl_attrs[] = {
+       &lustre_attr_grant_speed.attr,
+       &lustre_attr_grant_plan.attr,
+       &lustre_attr_recalc_period.attr,
+       &lustre_attr_server_lock_volume.attr,
++      &lustre_attr_client_lock_volume.attr,
++      &lustre_attr_recalc_time.attr,
+       &lustre_attr_limit.attr,
+       &lustre_attr_granted.attr,
+       &lustre_attr_cancel_rate.attr,
+@@ -867,8 +911,8 @@ int ldlm_pool_init(struct ldlm_pool *pl, struct ldlm_namespace *ns,
+       spin_lock_init(&pl->pl_lock);
+       atomic_set(&pl->pl_granted, 0);
+-      pl->pl_recalc_time = ktime_get_real_seconds();
+-      atomic_set(&pl->pl_lock_volume_factor, 1);
++      pl->pl_recalc_time = ktime_get_seconds();
++      atomic_set(&pl->pl_lock_volume_factor, 1 << 8);
+       atomic_set(&pl->pl_grant_rate, 0);
+       atomic_set(&pl->pl_cancel_rate, 0);
+@@ -1222,9 +1266,10 @@ static time64_t ldlm_pools_recalc_delay(enum ldlm_side side)
+       struct ldlm_namespace *ns;
+       struct ldlm_namespace *ns_old = NULL;
+       /* seconds of sleep if no active namespaces */
+-      time64_t delay = side == LDLM_NAMESPACE_SERVER ?
+-                               LDLM_POOL_SRV_DEF_RECALC_PERIOD :
+-                               LDLM_POOL_CLI_DEF_RECALC_PERIOD;
++      time64_t delay = ktime_get_seconds() +
++                       (side == LDLM_NAMESPACE_SERVER ?
++                        LDLM_POOL_SRV_DEF_RECALC_PERIOD :
++                        LDLM_POOL_CLI_DEF_RECALC_PERIOD);
+       int nr;
+       /* Recalc at least ldlm_namespace_nr(side) namespaces. */
+@@ -1375,18 +1420,33 @@ static void ldlm_pools_recalc_task(struct work_struct *ws)
+       /* Wake up the blocking threads from time to time. */
+       ldlm_bl_thread_wakeup();
++      delay -= ktime_get_seconds();
++      if (delay <= 0) {
++              /* Prevent too frequent recalculation. */
++              CDEBUG(D_DLMTRACE, "Negative interval(%lld)\n", delay);
++              delay = 1;
++      }
++
+       schedule_delayed_work(&ldlm_pools_recalc_work, cfs_time_seconds(delay));
+ }
+ int ldlm_pools_init(void)
+ {
++      time64_t delay;
++
+       DEF_SHRINKER_VAR(shsvar, ldlm_pools_srv_shrink,
+                        ldlm_pools_srv_count, ldlm_pools_srv_scan);
+       DEF_SHRINKER_VAR(shcvar, ldlm_pools_cli_shrink,
+                        ldlm_pools_cli_count, ldlm_pools_cli_scan);
+-      schedule_delayed_work(&ldlm_pools_recalc_work,
+-                            LDLM_POOL_CLI_DEF_RECALC_PERIOD);
++#ifdef HAVE_SERVER_SUPPORT
++      delay = min(LDLM_POOL_SRV_DEF_RECALC_PERIOD,
++                  LDLM_POOL_CLI_DEF_RECALC_PERIOD);
++#else
++      delay = LDLM_POOL_CLI_DEF_RECALC_PERIOD;
++#endif
++
++      schedule_delayed_work(&ldlm_pools_recalc_work, delay);
+       ldlm_pools_srv_shrinker = set_shrinker(DEFAULT_SEEKS, &shsvar);
+       ldlm_pools_cli_shrinker = set_shrinker(DEFAULT_SEEKS, &shcvar);